From: myungjoo.ham@samsung.com (MyungJoo Ham)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4
Date: Thu, 30 Jun 2011 16:50:48 +0900 [thread overview]
Message-ID: <BANLkTik-k+9=8coWpZO_zToYCm8iHfO3CQ@mail.gmail.com> (raw)
In-Reply-To: <004a01cc3662$65751a90$305f4fb0$%kim@samsung.com>
On Wed, Jun 29, 2011 at 10:42 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> MyungJoo Ham wrote:
>>
>> In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX
>> register, not ADCCON register. This patch corrects the behavior of
>> Samsung-ADC for such cpus.
>>
>> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> --
>> v2: No changes from v1. Resubmitted as a series of patches
>> ---
[]
>>
>> ?enum s3c_cpu_type {
>> ? ? ? TYPE_S3C24XX,
>> - ? ? TYPE_S3C64XX
>> + ? ? TYPE_S3C64XX,
>> + ? ? TYPE_S5P,
>> ?};
>
> How about S5PC100? Following is better for next if we cannot distinguish it
> by CPU.
>
> -enum s3c_cpu_type {
> - ? ? ? TYPE_S3C24XX,
> - ? ? ? TYPE_S3C64XX
> +enum samsung_adc_type {
> + ? ? ? TYPE_ADC24, ? ? ?/* S3C24XX */
> + ? ? ? TYPE_ADC64, ? ? ?/* S3C64XX, S5P64X0, S5PC100 */
> + ? ? ? TYPE_ADCV3 ? ? ?/* S5PV210, EXYNOS4210 */
> ?};
> ...
>
> TYPE_ADCV1 and V2?...
> Of course, the name can be changed...
I don't mind about these names as they are just internal values of adc.c.
Anyway, I prefer the last suggestion and I'll use TYPE_ADCV1/V2/V3.
Thanks.
--
MyungJoo Ham (???), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
next prev parent reply other threads:[~2011-06-30 7:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 8:30 [PATCH 1/2] Samsung SoC ADC: use regulator (VDD for ADC) MyungJoo Ham
2011-06-16 8:30 ` [PATCH 2/2] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4 MyungJoo Ham
2011-06-16 8:33 ` [PATCH] Samsung SoC ADC: register address definition for S5PV210/S5PC110/Exynos4 MyungJoo Ham
2011-06-16 8:47 ` [PATCH] Samsung SoC: header file revised to prevent declaring duplicated MyungJoo Ham
2011-06-22 9:10 ` Kukjin Kim
2011-06-18 15:06 ` [PATCH 1/2] Samsung SoC ADC: use regulator (VDD for ADC) Mark Brown
2011-06-20 5:16 ` MyungJoo Ham
2011-06-20 10:17 ` Mark Brown
2011-06-21 1:58 ` [PATCH v2 0/5] Update Samsung-SoC ADC (regulator / recent CPU support) MyungJoo Ham
2011-06-21 1:58 ` [PATCH v2 1/5] Samsung SoC ADC: use regulator (VDD for ADC) MyungJoo Ham
2011-06-21 10:43 ` Mark Brown
2011-06-22 2:40 ` MyungJoo Ham
2011-06-21 1:58 ` [PATCH v2 2/5] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4 MyungJoo Ham
2011-06-29 13:42 ` Kukjin Kim
2011-06-30 7:50 ` MyungJoo Ham [this message]
2011-06-21 1:58 ` [PATCH v2 3/5] ARM: Exynos4: Support ADC MyungJoo Ham
2011-06-29 13:52 ` Kukjin Kim
2011-06-21 1:58 ` [PATCH v2 4/5] ARM: S5PC110/S5PV210: " MyungJoo Ham
2011-06-21 1:58 ` [PATCH v2 5/5] Samsung SoC: header file revised to prevent declaring duplicated MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTik-k+9=8coWpZO_zToYCm8iHfO3CQ@mail.gmail.com' \
--to=myungjoo.ham@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).