From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: smp_twd: Reconfigure clockevents after cpufreq change
Date: Tue, 14 Jun 2011 07:50:45 +0200 [thread overview]
Message-ID: <BANLkTikEx0+SpwiWHqLNcs0oaLoN4LccHQ@mail.gmail.com> (raw)
In-Reply-To: <1306919711-30965-1-git-send-email-linus.walleij@stericsson.com>
Colin, Per Fransson noted this:
> From: Colin Cross <ccross@android.com>
> +/*
> + * Updates clockevent frequency when the cpu frequency changes.
> + * Called on the cpu that is changing frequency with interrupts disabled.
> + */
> +static void twd_update_frequency(void *data)
> +{
> + ? ? ? twd_timer_rate = clk_get_rate(twd_clk);
> +
> + ? ? ? clockevents_update_freq(__get_cpu_var(twd_ce), twd_timer_rate);
> +}
Will only update the clockevent on the CPU where the cpufreq notifier
gets called will it not? It's not called on each CPU AFAICT.
So this function has to traverse all CPUs in twd_ce.
Thanks,
Linus Walleij
next prev parent reply other threads:[~2011-06-14 5:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 9:15 [PATCH] ARM: smp_twd: Reconfigure clockevents after cpufreq change Linus Walleij
2011-06-14 5:50 ` Linus Walleij [this message]
2011-06-14 6:00 ` Colin Cross
2011-06-14 6:12 ` Santosh Shilimkar
2011-06-14 6:14 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 23:21 Colin Cross
2011-05-17 14:00 ` Santosh Shilimkar
2011-05-17 17:06 ` Colin Cross
2011-05-18 11:32 ` Santosh Shilimkar
2011-05-19 17:32 ` Linus Walleij
2011-05-19 23:26 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikEx0+SpwiWHqLNcs0oaLoN4LccHQ@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).