From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Use arch_spin_lock for unwind to avoid lockdep deadlock
Date: Tue, 17 May 2011 16:26:31 +0100 [thread overview]
Message-ID: <BANLkTikFcwxq7Wp42=MDMrH4dz7NARXWgQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1105171605080.3078@ionos>
On 17 May 2011 15:11, Thomas Gleixner <tglx@linutronix.de> wrote:
> When lockdep traces a lock taken in a module the arm unwinder takes
> unwind_lock which causes a recursive lockdep call deadlocking itself
> on the unwind_lock.
>
> Make unwind_lock an arch_spin_lock to avoid the lockdep call and use
> the raw_local_irq_save/restore() variants to avoid irq tracing as
> well.
>
> Reported-and-tested-by: Torben Hohn <torbenh@linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable at kernel.org
Looks fine to me (as the author of this code):
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
prev parent reply other threads:[~2011-05-17 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 14:11 [PATCH] arm: Use arch_spin_lock for unwind to avoid lockdep deadlock Thomas Gleixner
2011-05-17 14:20 ` Peter Zijlstra
2011-05-17 15:45 ` Thomas Gleixner
2011-05-17 19:31 ` Thomas Gleixner
2011-05-17 15:26 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikFcwxq7Wp42=MDMrH4dz7NARXWgQ@mail.gmail.com' \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).