From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][WAS:bcmai, axi] bcma: add Broadcom specific AMBA bus driver
Date: Sun, 8 May 2011 12:37:15 +0200 [thread overview]
Message-ID: <BANLkTikMruTibp64GjE9qP9r80JiHgAFXw@mail.gmail.com> (raw)
In-Reply-To: <20110508101609.GF27807@n2100.arm.linux.org.uk>
2011/5/8 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Sat, May 07, 2011 at 08:48:10PM +0200, Rafa? Mi?ecki wrote:
>> Really, what's wrong with that? Does it kill anyone's pet we print
>> this? We also do:
>> pr_err("Scanning failed because of wrong CID\n");
>> return -1;
>> While we could drop pr_err. Why to do this? Advanced used can always
>> check what -1 means.
>
> And why return -1 when we have a system of error codes? ?I _really_ wish
> people would stop returning -1 for "some random error occurred".
You commented on imagined code, but we actually do sth similar in code.
I did this because:
1) I had no idea what err code would be valid for invalid EPROM layout
(content). Nothing from include/asm-generic/errno-base.h sounds
reasonable.
2) I wanted to use different error codes for different EPROM layout
issues. Sometimes we don't get CIA block. Sometimes we don't get CIB
block. Sometimes there is problem with master port (not found in EPROM
when expected). They all would probably use the same errno.
Could you help me with this?
--
Rafa?
next prev parent reply other threads:[~2011-05-08 10:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 21:59 [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver Rafał Miłecki
2011-05-05 22:59 ` [PATCH][WAS:bcmai, axi] " Julian Calaby
2011-05-05 23:01 ` Rafał Miłecki
2011-05-06 14:05 ` Arnd Bergmann
2011-05-06 14:50 ` Rafał Miłecki
2011-05-07 13:34 ` Rafał Miłecki
2011-05-07 13:55 ` [PATCH][WAS:bcmai,axi] " Michael Büsch
2011-05-07 16:29 ` Arend van Spriel
2011-05-07 16:49 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 17:04 ` [PATCH][WAS:bcmai,axi] " Arend van Spriel
2011-05-07 17:20 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 17:51 ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 18:05 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 18:26 ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 18:48 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 19:02 ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 19:21 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 19:35 ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-08 1:44 ` Michael Büsch
2011-05-08 2:01 ` George Kashperko
2011-05-07 19:03 ` George Kashperko
2011-05-08 8:43 ` Arend van Spriel
2011-05-08 10:16 ` Russell King - ARM Linux
2011-05-08 10:37 ` Rafał Miłecki [this message]
2011-05-08 10:50 ` Russell King - ARM Linux
2011-05-08 15:06 ` [PATCH][WAS:bcmai, axi] " Arnd Bergmann
2011-05-08 15:25 ` Rafał Miłecki
2011-05-08 15:54 ` Arnd Bergmann
2011-05-08 14:47 ` Arnd Bergmann
2011-05-08 14:59 ` Rafał Miłecki
2011-05-08 15:59 ` Arnd Bergmann
2011-05-09 14:33 ` Rafał Miłecki
2011-05-09 15:37 ` Greg KH
2011-05-09 15:48 ` Rafał Miłecki
2011-05-07 16:13 ` Hauke Mehrtens
2011-05-07 16:23 ` Rafał Miłecki
2011-05-07 16:32 ` Hauke Mehrtens
2011-05-07 16:51 ` Rafał Miłecki
2011-05-07 17:24 ` Hauke Mehrtens
2011-05-07 17:35 ` Rafał Miłecki
2011-05-07 17:45 ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 22:42 ` Henry Ptasinski
2011-05-07 23:17 ` [PATCH][WAS:bcmai, axi] " Hauke Mehrtens
2011-05-08 12:48 ` Hauke Mehrtens
2011-05-08 12:55 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikMruTibp64GjE9qP9r80JiHgAFXw@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).