From: amit.kucheria@linaro.org (Amit Kucheria)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2] Add ARM cpu topology definition
Date: Wed, 22 Jun 2011 15:39:39 +0300 [thread overview]
Message-ID: <BANLkTikQt8dgikHUM5NfYLjWwHgwLbeQrg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikpasc40ubaHZvJoTVehLWtxvYQqQ@mail.gmail.com>
On Wed, Jun 22, 2011 at 3:20 PM, Vincent Guittot
<vincent.guittot@linaro.org> wrote:
> On 22 June 2011 12:14, Amit Kucheria <amit.kucheria@linaro.org> wrote:
>>> +
>>> +#define topology_physical_package_id(cpu) ? ?(cpu_topology[cpu].socket_id)
>>> +#define topology_core_id(cpu) ? ? ? ? ? ? ? ?(cpu_topology[cpu].core_id)
>>> +#define topology_core_cpumask(cpu) ? (&(cpu_topology[cpu].core_sibling))
>>> +#define topology_thread_cpumask(cpu) (&(cpu_topology[cpu].thread_sibling))
>>
>> These #defines are not used anywhere.
>
> They are used in topology.c driver and sched.c
>
>>
>>> +#define mc_capable() (cpu_topology[0].socket_id != -1)
>>> +#define smt_capable() ? ? ? ?(cpu_topology[0].thread_id != -1)
>>
>> Neither are these.
>
> They are used in sched.c
>
Ahh, sorry for the noise. Documentation/cputopology.txt is most illuminating.
prev parent reply other threads:[~2011-06-22 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 11:19 [RFC PATCH v2] Add ARM cpu topology definition Vincent Guittot
2011-06-22 10:14 ` Amit Kucheria
2011-06-22 12:20 ` Vincent Guittot
2011-06-22 12:39 ` Amit Kucheria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikQt8dgikHUM5NfYLjWwHgwLbeQrg@mail.gmail.com \
--to=amit.kucheria@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).