linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: balajitk@ti.com (T Krishnamoorthy, Balaji)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC
Date: Tue, 31 May 2011 19:02:34 +0530	[thread overview]
Message-ID: <BANLkTikhQ9esHA+WefbbfD=RUDWVsG9MbA@mail.gmail.com> (raw)
In-Reply-To: <20110531132614.GR11352@atomide.com>

On Tue, May 31, 2011 at 6:56 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Balaji T K <balajitk@ti.com> [110530 07:23]:
>> eMMC does not handle power off when not in sleep state,
>> Skip regulator disable during probe when eMMC is
>> not in known state - state left by bootloader.
>>
>> Resolves eMMC failure on OMAP4
>> mmc0: error -110 whilst initialising MMC card
>>
>> --- a/arch/arm/mach-omap2/hsmmc.h
>> +++ b/arch/arm/mach-omap2/hsmmc.h
>> @@ -18,6 +18,7 @@ struct omap2_hsmmc_info {
>> ? ? ? bool ? ?nonremovable; ? /* Nonremovable e.g. eMMC */
>> ? ? ? bool ? ?power_saving; ? /* Try to sleep or power off when possible */
>> ? ? ? bool ? ?no_off; ? ? ? ? /* power_saving and power is not to go off */
>> + ? ? bool ? ?no_off_init; ? ?/* no power off when not in MMC sleep state */
>> ? ? ? bool ? ?vcc_aux_disable_is_sleep; /* Regulator off remapped to sleep */
>> ? ? ? int ? ? gpio_cd; ? ? ? ?/* or -EINVAL */
>> ? ? ? int ? ? gpio_wp; ? ? ? ?/* or -EINVAL */
>
> Can't you use no_off for this too?

no_off is used for devices which do not want to disable regulator at any time.

newly introduced no_off_init is to skip disable regulator only during probe
After eMMC is put in sleep state (while suspend), regulator for eMMC
(VAUX1) can be disabled.

-- 
Thanks and Regards,
Balaji T K

>
> Tony
>

  reply	other threads:[~2011-05-31 13:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 14:25 [PATCH 0/2] ARM: OMAP4: fix MMC failure due to regulator enable/disable ops Balaji T K
2011-05-30 14:25 ` [PATCH 1/2] ARM: OMAP4: MMC: increase delay for pbias Balaji T K
2011-05-31 13:28   ` Tony Lindgren
2011-05-31 14:04   ` Kishore Kadiyala
2011-06-01  7:41   ` Tony Lindgren
2011-06-01  9:18     ` T Krishnamoorthy, Balaji
2011-05-30 14:25 ` [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC Balaji T K
2011-05-31 13:26   ` Tony Lindgren
2011-05-31 13:32     ` T Krishnamoorthy, Balaji [this message]
2011-05-31 13:45       ` Tony Lindgren
2011-05-31 14:41   ` Kishore Kadiyala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTikhQ9esHA+WefbbfD=RUDWVsG9MbA@mail.gmail.com' \
    --to=balajitk@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).