* [PATCH] gpio: ep93xx: move driver to drivers/gpio
@ 2011-05-31 19:49 H Hartley Sweeten
2011-05-31 20:40 ` Grant Likely
0 siblings, 1 reply; 9+ messages in thread
From: H Hartley Sweeten @ 2011-05-31 19:49 UTC (permalink / raw)
To: linux-arm-kernel
The GPIO driver should reside in drivers/gpio.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ryan Mallon <ryan@bluewatersys.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
---
diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
index 33ee2c8..6b7c41d 100644
--- a/arch/arm/mach-ep93xx/Makefile
+++ b/arch/arm/mach-ep93xx/Makefile
@@ -1,7 +1,7 @@
#
# Makefile for the linux kernel.
#
-obj-y := core.o clock.o dma-m2p.o gpio.o
+obj-y := core.o clock.o dma-m2p.o
obj-m :=
obj-n :=
obj- :=
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 342d634..7307302 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -86,6 +86,13 @@ config GPIO_IT8761E
help
Say yes here to support GPIO functionality of IT8761E super I/O chip.
+config GPIO_EP93XX
+ bool "Cirrus EP93xx GPIO support"
+ depends on ARCH_EP93XX
+ default y
+ help
+ Say yes here to support the Cirrus EP93xx GPIO peripheral.
+
config GPIO_EXYNOS4
bool "Samsung Exynos4 GPIO library support"
default y if CPU_EXYNOS4210
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 4ac7cb3..c8faabe 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_GPIO_ADP5520) += adp5520-gpio.o
obj-$(CONFIG_GPIO_ADP5588) += adp5588-gpio.o
obj-$(CONFIG_GPIO_BASIC_MMIO_CORE) += basic_mmio_gpio.o
obj-$(CONFIG_GPIO_BASIC_MMIO) += basic_mmio_gpio.o
+obj-$(CONFIG_GPIO_EP93XX) += gpio-ep93xx.o
obj-$(CONFIG_GPIO_EXYNOS4) += gpio-exynos4.o
obj-$(CONFIG_GPIO_I801) += gpio-i801.o
obj-$(CONFIG_GPIO_PLAT_SAMSUNG) += gpio-plat-samsung.o
diff --git a/arch/arm/mach-ep93xx/gpio.c b/drivers/gpio/gpio-ep93xx.c
similarity index 100%
rename from arch/arm/mach-ep93xx/gpio.c
rename to drivers/gpio/gpio-ep93xx.c
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-05-31 19:49 [PATCH] gpio: ep93xx: move driver to drivers/gpio H Hartley Sweeten
@ 2011-05-31 20:40 ` Grant Likely
2011-05-31 22:37 ` H Hartley Sweeten
0 siblings, 1 reply; 9+ messages in thread
From: Grant Likely @ 2011-05-31 20:40 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 31, 2011 at 1:49 PM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> The GPIO driver should reside in drivers/gpio.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <ryan@bluewatersys.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
>
> ---
>
> diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
> index 33ee2c8..6b7c41d 100644
> --- a/arch/arm/mach-ep93xx/Makefile
> +++ b/arch/arm/mach-ep93xx/Makefile
> @@ -1,7 +1,7 @@
> ?#
> ?# Makefile for the linux kernel.
> ?#
> -obj-y ? ? ? ? ? ? ? ? ?:= core.o clock.o dma-m2p.o gpio.o
> +obj-y ? ? ? ? ? ? ? ? ?:= core.o clock.o dma-m2p.o
> ?obj-m ? ? ? ? ? ? ? ? ?:=
> ?obj-n ? ? ? ? ? ? ? ? ?:=
> ?obj- ? ? ? ? ? ? ? ? ? :=
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 342d634..7307302 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -86,6 +86,13 @@ config GPIO_IT8761E
> ? ? ? ?help
> ? ? ? ? ?Say yes here to support GPIO functionality of IT8761E super I/O chip.
>
> +config GPIO_EP93XX
> + ? ? ? bool "Cirrus EP93xx GPIO support"
> + ? ? ? depends on ARCH_EP93XX
> + ? ? ? default y
> + ? ? ? help
> + ? ? ? ? Say yes here to support the Cirrus EP93xx GPIO peripheral.
> +
Do you really want a user-visible Kconfig symbol here? If it cannot
be built as a module, then I suspect that for most on-chip gpio
controllers they should just be enabled unconditionally on the SoC's
Kconfig symbol.
g.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-05-31 20:40 ` Grant Likely
@ 2011-05-31 22:37 ` H Hartley Sweeten
2011-05-31 23:28 ` Grant Likely
0 siblings, 1 reply; 9+ messages in thread
From: H Hartley Sweeten @ 2011-05-31 22:37 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, May 31, 2011 1:41 PM, Grant Likely wrote:
> On Tue, May 31, 2011 at 1:49 PM, H Hartley Sweeten wrote:
>> The GPIO driver should reside in drivers/gpio.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Ryan Mallon <ryan@bluewatersys.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>
>> ---
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 342d634..7307302 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -86,6 +86,13 @@ config GPIO_IT8761E
>> ? ? ? ?help
>> ? ? ? ? ?Say yes here to support GPIO functionality of IT8761E super I/O chip.
>>
>> +config GPIO_EP93XX
>> + ? ? ? bool "Cirrus EP93xx GPIO support"
>> + ? ? ? depends on ARCH_EP93XX
>> + ? ? ? default y
>> + ? ? ? help
>> + ? ? ? ? Say yes here to support the Cirrus EP93xx GPIO peripheral.
>> +
>
> Do you really want a user-visible Kconfig symbol here? If it cannot
> be built as a module, then I suspect that for most on-chip gpio
> controllers they should just be enabled unconditionally on the SoC's
> Kconfig symbol.
Grant,
No, I a user-visible symbol is not needed. Should I change this to:
+config GPIO_EP93XX
+ ? ? ? bool
+ ? ? ? depends on ARCH_EP93XX
+ ? ? ? default y
Or like the Samsung drivers, without the visibility:
+config GPIO_EP93XX
+ ? ? ? bool
+ ? ? ? depends on ARM
+ ? ? ? default y if ARCH_EP93XX
Also, should the help information remain with a hidden Kconfig symbol?
Thanks,
Hartley
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-05-31 22:37 ` H Hartley Sweeten
@ 2011-05-31 23:28 ` Grant Likely
2011-06-01 8:26 ` Russell King - ARM Linux
0 siblings, 1 reply; 9+ messages in thread
From: Grant Likely @ 2011-05-31 23:28 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 31, 2011 at 4:37 PM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> On Tuesday, May 31, 2011 1:41 PM, Grant Likely wrote:
>> On Tue, May 31, 2011 at 1:49 PM, H Hartley Sweeten wrote:
>>> The GPIO driver should reside in drivers/gpio.
>>>
>>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>>> Cc: Ryan Mallon <ryan@bluewatersys.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>>
>>> ---
>>>
>>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>>> index 342d634..7307302 100644
>>> --- a/drivers/gpio/Kconfig
>>> +++ b/drivers/gpio/Kconfig
>>> @@ -86,6 +86,13 @@ config GPIO_IT8761E
>>> ? ? ? ?help
>>> ? ? ? ? ?Say yes here to support GPIO functionality of IT8761E super I/O chip.
>>>
>>> +config GPIO_EP93XX
>>> + ? ? ? bool "Cirrus EP93xx GPIO support"
>>> + ? ? ? depends on ARCH_EP93XX
>>> + ? ? ? default y
>>> + ? ? ? help
>>> + ? ? ? ? Say yes here to support the Cirrus EP93xx GPIO peripheral.
>>> +
>>
>> Do you really want a user-visible Kconfig symbol here? ?If it cannot
>> be built as a module, then I suspect that for most on-chip gpio
>> controllers they should just be enabled unconditionally on the SoC's
>> Kconfig symbol.
>
> Grant,
>
> No, I a user-visible symbol is not needed. ?Should I change this to:
>
> +config GPIO_EP93XX
> + ? ? ? bool
> + ? ? ? depends on ARCH_EP93XX
> + ? ? ? default y
>
> Or like the Samsung drivers, without the visibility:
>
> +config GPIO_EP93XX
> + ? ? ? bool
> + ? ? ? depends on ARM
> + ? ? ? default y if ARCH_EP93XX
I like the former.
> Also, should the help information remain with a hidden Kconfig symbol?
The help text is pretty vanilla. Drop it.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-05-31 23:28 ` Grant Likely
@ 2011-06-01 8:26 ` Russell King - ARM Linux
2011-06-01 16:46 ` Grant Likely
0 siblings, 1 reply; 9+ messages in thread
From: Russell King - ARM Linux @ 2011-06-01 8:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 31, 2011 at 05:28:26PM -0600, Grant Likely wrote:
> On Tue, May 31, 2011 at 4:37 PM, H Hartley Sweeten
> <hartleys@visionengravers.com> wrote:
> > On Tuesday, May 31, 2011 1:41 PM, Grant Likely wrote:
> >> On Tue, May 31, 2011 at 1:49 PM, H Hartley Sweeten wrote:
> >>> The GPIO driver should reside in drivers/gpio.
> >>>
> >>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> >>> Cc: Ryan Mallon <ryan@bluewatersys.com>
> >>> Cc: Grant Likely <grant.likely@secretlab.ca>
> >>>
> >>> ---
> >>>
> >>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> >>> index 342d634..7307302 100644
> >>> --- a/drivers/gpio/Kconfig
> >>> +++ b/drivers/gpio/Kconfig
> >>> @@ -86,6 +86,13 @@ config GPIO_IT8761E
> >>> ? ? ? ?help
> >>> ? ? ? ? ?Say yes here to support GPIO functionality of IT8761E super I/O chip.
> >>>
> >>> +config GPIO_EP93XX
> >>> + ? ? ? bool "Cirrus EP93xx GPIO support"
> >>> + ? ? ? depends on ARCH_EP93XX
> >>> + ? ? ? default y
> >>> + ? ? ? help
> >>> + ? ? ? ? Say yes here to support the Cirrus EP93xx GPIO peripheral.
> >>> +
> >>
> >> Do you really want a user-visible Kconfig symbol here? ?If it cannot
> >> be built as a module, then I suspect that for most on-chip gpio
> >> controllers they should just be enabled unconditionally on the SoC's
> >> Kconfig symbol.
> >
> > Grant,
> >
> > No, I a user-visible symbol is not needed. ?Should I change this to:
> >
> > +config GPIO_EP93XX
> > + ? ? ? bool
> > + ? ? ? depends on ARCH_EP93XX
> > + ? ? ? default y
> >
> > Or like the Samsung drivers, without the visibility:
> >
> > +config GPIO_EP93XX
> > + ? ? ? bool
> > + ? ? ? depends on ARM
> > + ? ? ? default y if ARCH_EP93XX
>
> I like the former.
Even better is:
config GPIO_EP93XX
def_bool y
depends on ARCH_EP93XX
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-06-01 8:26 ` Russell King - ARM Linux
@ 2011-06-01 16:46 ` Grant Likely
2011-06-01 17:24 ` H Hartley Sweeten
0 siblings, 1 reply; 9+ messages in thread
From: Grant Likely @ 2011-06-01 16:46 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 1, 2011 at 2:26 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, May 31, 2011 at 05:28:26PM -0600, Grant Likely wrote:
>> > [...]Should I change this to:
>> >
>> > +config GPIO_EP93XX
>> > + ? ? ? bool
>> > + ? ? ? depends on ARCH_EP93XX
>> > + ? ? ? default y
>> >
>> > Or like the Samsung drivers, without the visibility:
>> >
>> > +config GPIO_EP93XX
>> > + ? ? ? bool
>> > + ? ? ? depends on ARM
>> > + ? ? ? default y if ARCH_EP93XX
>>
>> I like the former.
>
> Even better is:
>
> config GPIO_EP93XX
> ? ? ? ?def_bool y
> ? ? ? ?depends on ARCH_EP93XX
Yup.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-06-01 16:46 ` Grant Likely
@ 2011-06-01 17:24 ` H Hartley Sweeten
2011-06-02 2:44 ` Kyungmin Park
0 siblings, 1 reply; 9+ messages in thread
From: H Hartley Sweeten @ 2011-06-01 17:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday, June 01, 2011 9:46 AM, Grant Likely wrote:
> On Wed, Jun 1, 2011 at 2:26 AM, Russell King - ARM Linux wrote:
>> On Tue, May 31, 2011 at 05:28:26PM -0600, Grant Likely wrote:
>>>> [...]Should I change this to:
>>>>
>>>> +config GPIO_EP93XX
>>>> + ? ? ? bool
>>>> + ? ? ? depends on ARCH_EP93XX
>>>> + ? ? ? default y
>>>>
>>>> Or like the Samsung drivers, without the visibility:
>>>>
>>>> +config GPIO_EP93XX
>>>> + ? ? ? bool
>>>> + ? ? ? depends on ARM
>>>> + ? ? ? default y if ARCH_EP93XX
>>>
>>> I like the former.
>>
>> Even better is:
>>
>> config GPIO_EP93XX
>> ? ? ? ?def_bool y
>> ? ? ? ?depends on ARCH_EP93XX
>
> Yup.
Shouldn't the Samsung gpio drivers be handled the same way?
Also, the depends on ARM is redundant. The other symbols are only
available when ARM is defined.
Something like this.
gpio: Samsung: make Kconfig options def_bool
The Samsung GPIO drivers are always built-in when the relevant
platform is selected. Change the Kconfig symbol to def_bool y
dependant on the platform.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 18c0b31..2e3cd11 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -87,32 +87,20 @@ config GPIO_IT8761E
Say yes here to support GPIO functionality of IT8761E super I/O chip.
config GPIO_EXYNOS4
- bool "Samsung Exynos4 GPIO library support"
- default y
- depends on ARM && CPU_EXYNOS4210
- help
- Say yes here to support Samsung Exynos4 series SoCs GPIO library
+ def_bool y
+ depends on CPU_EXYNOS4210
config GPIO_PLAT_SAMSUNG
- bool "Samsung SoCs GPIO library support"
- default y
- depends on ARM && SAMSUNG_GPIOLIB_4BIT
- help
- Say yes here to support Samsung SoCs GPIO library
+ def_bool y
+ depends on SAMSUNG_GPIOLIB_4BIT
config GPIO_S5PC100
- bool "Samsung S5PC100 GPIO library support"
- default y
- depends on ARM && CPU_S5PC100
- help
- Say yes here to support Samsung S5PC100 SoCs GPIO library
+ def_bool y
+ depends on CPU_S5PC100
config GPIO_S5PV210
- bool "Samsung S5PV210/S5PC110 GPIO library support"
- default y
- depends on ARM && CPU_S5PV210
- help
- Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
+ def_bool y
+ depends on CPU_S5PV210
config GPIO_PL061
bool "PrimeCell PL061 GPIO support"
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-06-01 17:24 ` H Hartley Sweeten
@ 2011-06-02 2:44 ` Kyungmin Park
2011-06-02 16:55 ` H Hartley Sweeten
0 siblings, 1 reply; 9+ messages in thread
From: Kyungmin Park @ 2011-06-02 2:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 2, 2011 at 2:24 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> On Wednesday, June 01, 2011 9:46 AM, Grant Likely wrote:
>> On Wed, Jun 1, 2011 at 2:26 AM, Russell King - ARM Linux wrote:
>>> On Tue, May 31, 2011 at 05:28:26PM -0600, Grant Likely wrote:
>>>>> [...]Should I change this to:
>>>>>
>>>>> +config GPIO_EP93XX
>>>>> + ? ? ? bool
>>>>> + ? ? ? depends on ARCH_EP93XX
>>>>> + ? ? ? default y
>>>>>
>>>>> Or like the Samsung drivers, without the visibility:
>>>>>
>>>>> +config GPIO_EP93XX
>>>>> + ? ? ? bool
>>>>> + ? ? ? depends on ARM
>>>>> + ? ? ? default y if ARCH_EP93XX
>>>>
>>>> I like the former.
>>>
>>> Even better is:
>>>
>>> config GPIO_EP93XX
>>> ? ? ? ?def_bool y
>>> ? ? ? ?depends on ARCH_EP93XX
>>
>> Yup.
>
> Shouldn't the Samsung gpio drivers be handled the same way?
>
> Also, the depends on ARM is redundant. ?The other symbols are only
> available when ARM is defined.
>
> Something like this.
>
>
> gpio: Samsung: make Kconfig options def_bool
>
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected. ?Change the Kconfig symbol to def_bool y
> dependant on the platform.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> ---
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 18c0b31..2e3cd11 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
> ? ? ? ? ?Say yes here to support GPIO functionality of IT8761E super I/O chip.
>
> ?config GPIO_EXYNOS4
> - ? ? ? bool "Samsung Exynos4 GPIO library support"
> - ? ? ? default y
> - ? ? ? depends on ARM && CPU_EXYNOS4210
> - ? ? ? help
> - ? ? ? ? Say yes here to support Samsung Exynos4 series SoCs GPIO library
> + ? ? ? def_bool y
> + ? ? ? depends on CPU_EXYNOS4210
>
> ?config GPIO_PLAT_SAMSUNG
> - ? ? ? bool "Samsung SoCs GPIO library support"
> - ? ? ? default y
> - ? ? ? depends on ARM && SAMSUNG_GPIOLIB_4BIT
> - ? ? ? help
> - ? ? ? ? Say yes here to support Samsung SoCs GPIO library
> + ? ? ? def_bool y
> + ? ? ? depends on SAMSUNG_GPIOLIB_4BIT
>
> ?config GPIO_S5PC100
> - ? ? ? bool "Samsung S5PC100 GPIO library support"
> - ? ? ? default y
> - ? ? ? depends on ARM && CPU_S5PC100
> - ? ? ? help
> - ? ? ? ? Say yes here to support Samsung S5PC100 SoCs GPIO library
> + ? ? ? def_bool y
> + ? ? ? depends on CPU_S5PC100
>
> ?config GPIO_S5PV210
> - ? ? ? bool "Samsung S5PV210/S5PC110 GPIO library support"
> - ? ? ? default y
> - ? ? ? depends on ARM && CPU_S5PV210
> - ? ? ? help
> - ? ? ? ? Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> + ? ? ? def_bool y
> + ? ? ? depends on CPU_S5PV210
>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ?config GPIO_PL061
> ? ? ? ?bool "PrimeCell PL061 GPIO support"
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] gpio: ep93xx: move driver to drivers/gpio
2011-06-02 2:44 ` Kyungmin Park
@ 2011-06-02 16:55 ` H Hartley Sweeten
0 siblings, 0 replies; 9+ messages in thread
From: H Hartley Sweeten @ 2011-06-02 16:55 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday, June 01, 2011 7:45 PM, Kyungmin Park wrote:
> On Thu, Jun 2, 2011 at 2:24 AM, H Hartley Sweeten
>> gpio: Samsung: make Kconfig options def_bool
>>
>> The Samsung GPIO drivers are always built-in when the relevant
>> platform is selected. ?Change the Kconfig symbol to def_bool y
>> dependant on the platform.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>>
>> ---
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 18c0b31..2e3cd11 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -87,32 +87,20 @@ config GPIO_IT8761E
>> ? ? ? ? ?Say yes here to support GPIO functionality of IT8761E super I/O chip.
>>
>> ?config GPIO_EXYNOS4
>> - ? ? ? bool "Samsung Exynos4 GPIO library support"
>> - ? ? ? default y
>> - ? ? ? depends on ARM && CPU_EXYNOS4210
>> - ? ? ? help
>> - ? ? ? ? Say yes here to support Samsung Exynos4 series SoCs GPIO library
>> + ? ? ? def_bool y
>> + ? ? ? depends on CPU_EXYNOS4210
>>
>> ?config GPIO_PLAT_SAMSUNG
>> - ? ? ? bool "Samsung SoCs GPIO library support"
>> - ? ? ? default y
>> - ? ? ? depends on ARM && SAMSUNG_GPIOLIB_4BIT
>> - ? ? ? help
>> - ? ? ? ? Say yes here to support Samsung SoCs GPIO library
>> + ? ? ? def_bool y
>> + ? ? ? depends on SAMSUNG_GPIOLIB_4BIT
>>
>> ?config GPIO_S5PC100
>> - ? ? ? bool "Samsung S5PC100 GPIO library support"
>> - ? ? ? default y
>> - ? ? ? depends on ARM && CPU_S5PC100
>> - ? ? ? help
>> - ? ? ? ? Say yes here to support Samsung S5PC100 SoCs GPIO library
>> + ? ? ? def_bool y
>> + ? ? ? depends on CPU_S5PC100
>>
>> ?config GPIO_S5PV210
>> - ? ? ? bool "Samsung S5PV210/S5PC110 GPIO library support"
>> - ? ? ? default y
>> - ? ? ? depends on ARM && CPU_S5PV210
>> - ? ? ? help
>> - ? ? ? ? Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
>> + ? ? ? def_bool y
>> + ? ? ? depends on CPU_S5PV210
>>
>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Kyungmin,
Thanks. I'll repost this as a proper patch in a new email.
Regards,
Hartley
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-06-02 16:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-31 19:49 [PATCH] gpio: ep93xx: move driver to drivers/gpio H Hartley Sweeten
2011-05-31 20:40 ` Grant Likely
2011-05-31 22:37 ` H Hartley Sweeten
2011-05-31 23:28 ` Grant Likely
2011-06-01 8:26 ` Russell King - ARM Linux
2011-06-01 16:46 ` Grant Likely
2011-06-01 17:24 ` H Hartley Sweeten
2011-06-02 2:44 ` Kyungmin Park
2011-06-02 16:55 ` H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).