From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Include Makefile.boot only when it exists
Date: Wed, 20 Apr 2011 17:27:06 +0800 [thread overview]
Message-ID: <BANLkTiknesdF7cMZ=RGJAh75aW_wRpyj-w@mail.gmail.com> (raw)
In-Reply-To: <20110420083258.GB1517@S2100-06.ap.freescale.net>
On Wed, Apr 20, 2011 at 4:32 PM, Shawn Guo <shawn.guo@freescale.com> wrote:
> Hi Eric,
>
> On Mon, Apr 18, 2011 at 01:19:36PM +0800, Eric Miao wrote:
>> If AUTO_ZRELADDR is selected and target is not uImage, the existence
>> of Makefile.boot could be optional.
>>
>> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>> ---
>> ?arch/arm/boot/Makefile | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
>> index 9128fdd..277368f 100644
>> --- a/arch/arm/boot/Makefile
>> +++ b/arch/arm/boot/Makefile
>> @@ -14,7 +14,7 @@
>> ?MKIMAGE ? ? ? ? := $(srctree)/scripts/mkuboot.sh
>>
>> ?ifneq ($(MACHINE),)
>> -include $(srctree)/$(MACHINE)/Makefile.boot
>> +-include $(srctree)/$(MACHINE)/Makefile.boot
> ? ^ Makefile grammar?
Yes. GNU make will only include the file if it _exists_.
>> ?endif
>>
> I do not understand the patch. ?But looking at the patch below, the
> dtb rule uses Makefile.boot too.
>
Since originally there are only definitions like zreladdr defined in
Makefile.boot,
and with AUTO_ZRELADDR, some platforms do not need this definition any
more, which makes Makefile.boot useless on these platforms. Yet it does now
look like Makefile.boot is so far the best place for these DTB rules.
> [PATCH v2] arm/dt: Add a make rule to build dtb for enabled boards
> http://lists.infradead.org/pipermail/linux-arm-kernel/2011-April/047129.html
>
> --
> Regards,
> Shawn
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2011-04-20 9:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 5:19 [PATCH] ARM: Include Makefile.boot only when it exists Eric Miao
2011-04-20 8:32 ` Shawn Guo
2011-04-20 9:27 ` Eric Miao [this message]
2011-04-20 9:41 ` Shawn Guo
2011-04-20 9:48 ` Uwe Kleine-König
2011-04-28 15:27 ` Russell King - ARM Linux
2011-04-29 1:00 ` Nicolas Pitre
2011-04-29 7:53 ` Russell King - ARM Linux
2011-04-29 12:32 ` Nicolas Pitre
2011-04-29 13:33 ` Russell King - ARM Linux
2011-04-29 19:43 ` Nicolas Pitre
2011-04-30 8:44 ` Brian Swetland
2011-05-03 10:25 ` Mark Brown
2011-04-29 13:32 ` Shawn Guo
2011-04-29 13:47 ` Russell King - ARM Linux
2011-05-03 16:08 ` Mark Brown
2011-05-01 6:05 ` Richard Cochran
2011-05-01 6:09 ` Richard Cochran
2011-05-01 13:07 ` Nicolas Pitre
2011-05-01 15:59 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTiknesdF7cMZ=RGJAh75aW_wRpyj-w@mail.gmail.com' \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).