From: cavokz@gmail.com (Domenico Andreoli)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 2/2] Add GPIO DT support to s3c24xx
Date: Mon, 11 Apr 2011 10:53:24 +0200 [thread overview]
Message-ID: <BANLkTim+CuRa=zFDFS3Qgwov4TW4NDK-Lw@mail.gmail.com> (raw)
In-Reply-To: <20110411064719.GD4439@angua.secretlab.ca>
On Mon, Apr 11, 2011 at 8:47 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Sun, Apr 10, 2011 at 05:33:16PM +0200, Domenico Andreoli wrote:
>>
>> ?arch/arm/plat-s3c24xx/gpiolib.c | ? 45 ++++++++++++++++++++++++++++++++++++++++
>> ?1 file changed, 45 insertions(+)
>>
>> Index: b/arch/arm/plat-s3c24xx/gpiolib.c
>> ===================================================================
>> --- a/arch/arm/plat-s3c24xx/gpiolib.c 2011-04-10 16:24:59.000000000 +0200
>> +++ b/arch/arm/plat-s3c24xx/gpiolib.c 2011-04-10 17:12:32.000000000 +0200
>> @@ -19,6 +19,8 @@
>> ?#include <linux/ioport.h>
>> ?#include <linux/io.h>
>> ?#include <linux/gpio.h>
>> +#include <linux/of.h>
>> +#include <linux/of_address.h>
>>
>> ?#include <plat/gpio-core.h>
>> ?#include <plat/gpio-cfg.h>
>> @@ -97,6 +99,9 @@
>> ? ? ? ? ? ? ? ? ? ? ? .direction_input ? ? ? ?= s3c24xx_gpiolib_banka_input,
>> ? ? ? ? ? ? ? ? ? ? ? .direction_output ? ? ? = s3c24xx_gpiolib_banka_output,
>> ? ? ? ? ? ? ? },
>> +#ifdef CONFIG_OF_GPIO
>> + ? ? ? ? ? ? .dt_compat = "samsung,s3c2410-gpio-a",
>> +#endif
>
> The '-a' bit I suspect is wrong. ?Aren't all the gpio banks of the same type?
no, the first bank is made of output-only gpio.
-----[ Domenico Andreoli, aka cavok
?--[ http://www.dandreoli.com/gpgkey.asc
?? ---[ 3A0F 2F80 F79C 678A 8936? 4FEE 0677 9033 A20E BC50
next prev parent reply other threads:[~2011-04-11 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110410152735.338798127@gmail.com>
2011-04-10 15:33 ` [patch 1/2] Add dt_compat field to struct s3c_gpio_chip Domenico Andreoli
2011-04-11 6:41 ` Grant Likely
2011-04-10 15:33 ` [patch 2/2] Add GPIO DT support to s3c24xx Domenico Andreoli
2011-04-11 6:47 ` Grant Likely
2011-04-11 8:53 ` Domenico Andreoli [this message]
2011-04-11 9:33 ` [PATCH v3] " Domenico Andreoli
2011-04-15 0:08 ` Marek Vasut
[not found] <20110407163322.465935232@gmail.com>
2011-04-07 16:39 ` [patch 2/2] " Domenico Andreoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTim+CuRa=zFDFS3Qgwov4TW4NDK-Lw@mail.gmail.com' \
--to=cavokz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).