From: saeed.bishara@gmail.com (saeed bishara)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: remove unneeded check of the cache_is_vipt_nonaliasing()
Date: Sun, 15 May 2011 17:48:24 +0300 [thread overview]
Message-ID: <BANLkTim=dmHg_vyfYN6m73z6SQXiVzM7vg@mail.gmail.com> (raw)
In-Reply-To: <1305225183-15521-1-git-send-email-saeed@marvell.com>
On Thu, May 12, 2011 at 9:33 PM, Saeed Bishara <saeed@marvell.com> wrote:
>
> Signed-off-by: Saeed Bishara <saeed@marvell.com>
> ---
> ?arch/arm/mm/flush.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c
> index 2b269c9..f1b7998 100644
> --- a/arch/arm/mm/flush.c
> +++ b/arch/arm/mm/flush.c
> @@ -253,8 +253,8 @@ void __sync_icache_dcache(pte_t pteval)
>
> ? ? ? ?if (!test_and_set_bit(PG_dcache_clean, &page->flags))
> ? ? ? ? ? ? ? ?__flush_dcache_page(mapping, page);
> - ? ? ? /* pte_exec() already checked above for non-aliasing VIPT cache */
> - ? ? ? if (cache_is_vipt_nonaliasing() || pte_exec(pteval))
> +
> + ? ? ? if (pte_exec(pteval))
> ? ? ? ? ? ? ? ?__flush_icache_all();
> ?}
> ?#endif
can you have I a look at this patch?
the __sync_icache_dcache() returns if (cache_is_vipt_nonaliasing() &&
!pte_exec(pteval)), so later, the if (cache_is_vipt_nonaliasing() ||
pte_exec(pteval)) should be equivalent to if (pte_exec(pteval))
saeed
next prev parent reply other threads:[~2011-05-15 14:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 18:33 [PATCH 1/2] ARM: remove unneeded check of the cache_is_vipt_nonaliasing() Saeed Bishara
2011-05-12 18:33 ` [PATCH 2/2] ARM: fix the note about dcache lazy flushing for SMP systems Saeed Bishara
2011-05-16 7:51 ` saeed bishara
2011-05-16 8:46 ` Catalin Marinas
2011-05-15 14:48 ` saeed bishara [this message]
2011-05-15 21:11 ` [PATCH 1/2] ARM: remove unneeded check of the cache_is_vipt_nonaliasing() Catalin Marinas
2011-05-16 7:39 ` saeed bishara
2011-05-16 8:38 ` Catalin Marinas
2011-05-16 10:00 ` saeed bishara
2011-05-16 11:58 ` Catalin Marinas
2011-05-16 12:13 ` Saeed Bishara
2011-05-16 15:42 ` Catalin Marinas
2011-05-16 11:00 ` Russell King - ARM Linux
2011-05-16 11:10 ` Saeed Bishara
2011-05-16 11:11 ` Catalin Marinas
2011-05-16 11:15 ` Saeed Bishara
2011-05-16 13:42 ` Russell King - ARM Linux
2011-05-16 14:43 ` saeed bishara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTim=dmHg_vyfYN6m73z6SQXiVzM7vg@mail.gmail.com' \
--to=saeed.bishara@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).