From: minipli@googlemail.com (Mathias Krause)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm, exec: remove redundant set_fs(USER_DS)
Date: Fri, 10 Jun 2011 15:53:24 +0200 [thread overview]
Message-ID: <BANLkTimFL44XRDeA6z6pvKGw-zpcdsNUEw@mail.gmail.com> (raw)
In-Reply-To: <20110610134821.GL24424@n2100.arm.linux.org.uk>
On Fri, Jun 10, 2011 at 3:48 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Jun 10, 2011 at 03:08:57PM +0200, Mathias Krause wrote:
>> The address limit is already set in flush_old_exec() so this
>> set_fs(USER_DS) is redundant.
>
> Please show where and how this is done. ?I've looked and can't see
> any equivalent call to set_fs() in flush_old_exec().
Before dac853a (exec: delay address limit change until point of no
return) it was done in search_binary_handler(), now it is done in
flush_old_exec(). Either way set_fs(USER_DS) was/gets called before
start_thread() so the call there is redundant.
Mathias
next prev parent reply other threads:[~2011-06-10 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTinv1teZEHMK0qymaVdcxPOErpqSyg@mail.gmail.com>
2011-06-10 13:08 ` [PATCH] arm, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 13:48 ` Russell King - ARM Linux
2011-06-10 13:53 ` Mathias Krause [this message]
2011-06-27 4:29 ` Mathias Krause
[not found] <BANLkTiknCeAxe30MJdVTxDom+ko8+EDQ4A@mail.gmail.com>
[not found] ` <1307642718-22257-1-git-send-email-minipli@googlemail.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimFL44XRDeA6z6pvKGw-zpcdsNUEw@mail.gmail.com \
--to=minipli@googlemail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).