* [PATCH] arm, exec: remove redundant set_fs(USER_DS) [not found] <BANLkTinv1teZEHMK0qymaVdcxPOErpqSyg@mail.gmail.com> @ 2011-06-10 13:08 ` Mathias Krause 2011-06-10 13:48 ` Russell King - ARM Linux 0 siblings, 1 reply; 4+ messages in thread From: Mathias Krause @ 2011-06-10 13:08 UTC (permalink / raw) To: linux-arm-kernel The address limit is already set in flush_old_exec() so this set_fs(USER_DS) is redundant. Signed-off-by: Mathias Krause <minipli@googlemail.com> --- arch/arm/include/asm/processor.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/include/asm/processor.h b/arch/arm/include/asm/processor.h index b2d9df5..3962caf 100644 --- a/arch/arm/include/asm/processor.h +++ b/arch/arm/include/asm/processor.h @@ -55,7 +55,6 @@ struct thread_struct { #define start_thread(regs,pc,sp) \ ({ \ unsigned long *stack = (unsigned long *)sp; \ - set_fs(USER_DS); \ memset(regs->uregs, 0, sizeof(regs->uregs)); \ if (current->personality & ADDR_LIMIT_32BIT) \ regs->ARM_cpsr = USR_MODE; \ -- 1.5.6.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm, exec: remove redundant set_fs(USER_DS) 2011-06-10 13:08 ` [PATCH] arm, exec: remove redundant set_fs(USER_DS) Mathias Krause @ 2011-06-10 13:48 ` Russell King - ARM Linux 2011-06-10 13:53 ` Mathias Krause 0 siblings, 1 reply; 4+ messages in thread From: Russell King - ARM Linux @ 2011-06-10 13:48 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jun 10, 2011 at 03:08:57PM +0200, Mathias Krause wrote: > The address limit is already set in flush_old_exec() so this > set_fs(USER_DS) is redundant. Please show where and how this is done. I've looked and can't see any equivalent call to set_fs() in flush_old_exec(). ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm, exec: remove redundant set_fs(USER_DS) 2011-06-10 13:48 ` Russell King - ARM Linux @ 2011-06-10 13:53 ` Mathias Krause 2011-06-27 4:29 ` Mathias Krause 0 siblings, 1 reply; 4+ messages in thread From: Mathias Krause @ 2011-06-10 13:53 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jun 10, 2011 at 3:48 PM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Fri, Jun 10, 2011 at 03:08:57PM +0200, Mathias Krause wrote: >> The address limit is already set in flush_old_exec() so this >> set_fs(USER_DS) is redundant. > > Please show where and how this is done. ?I've looked and can't see > any equivalent call to set_fs() in flush_old_exec(). Before dac853a (exec: delay address limit change until point of no return) it was done in search_binary_handler(), now it is done in flush_old_exec(). Either way set_fs(USER_DS) was/gets called before start_thread() so the call there is redundant. Mathias ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm, exec: remove redundant set_fs(USER_DS) 2011-06-10 13:53 ` Mathias Krause @ 2011-06-27 4:29 ` Mathias Krause 0 siblings, 0 replies; 4+ messages in thread From: Mathias Krause @ 2011-06-27 4:29 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jun 10, 2011 at 3:53 PM, Mathias Krause <minipli@googlemail.com> wrote: > On Fri, Jun 10, 2011 at 3:48 PM, Russell King - ARM Linux > <linux@arm.linux.org.uk> wrote: >> On Fri, Jun 10, 2011 at 03:08:57PM +0200, Mathias Krause wrote: >>> The address limit is already set in flush_old_exec() so this >>> set_fs(USER_DS) is redundant. >> >> Please show where and how this is done. ?I've looked and can't see >> any equivalent call to set_fs() in flush_old_exec(). > > Before dac853a (exec: delay address limit change until point of no > return) it was done in search_binary_handler(), now it is done in > flush_old_exec(). Either way set_fs(USER_DS) was/gets called before > start_thread() so the call there is redundant. Russell, any new opinion on this? Mathias ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <BANLkTiknCeAxe30MJdVTxDom+ko8+EDQ4A@mail.gmail.com>]
[parent not found: <1307642718-22257-1-git-send-email-minipli@googlemail.com>]
end of thread, other threads:[~2011-06-27 4:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BANLkTinv1teZEHMK0qymaVdcxPOErpqSyg@mail.gmail.com>
2011-06-10 13:08 ` [PATCH] arm, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 13:48 ` Russell King - ARM Linux
2011-06-10 13:53 ` Mathias Krause
2011-06-27 4:29 ` Mathias Krause
[not found] <BANLkTiknCeAxe30MJdVTxDom+ko8+EDQ4A@mail.gmail.com>
[not found] ` <1307642718-22257-1-git-send-email-minipli@googlemail.com>
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).