From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa: correct icip irq handling
Date: Tue, 31 May 2011 13:31:02 +0800 [thread overview]
Message-ID: <BANLkTimG2bKvQ4u_Hq=dyJ56GL1Z4oBrug@mail.gmail.com> (raw)
In-Reply-To: <1306618093-6572-1-git-send-email-dbaryshkov@gmail.com>
On Sun, May 29, 2011 at 5:28 AM, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
> IRQ handling on PXA25x is broken if PXA_HAVE_ISA_IRQS is enabled (then
> all PXA irqs are shifted to start from 16, but icip_handle_irq doesn't
> work in this case. Use PXA_IRQ to correct IRQ numbers in icip_handle_irq.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Applied. Unfortunately, Russell didn't seem to have pulled, so we may need
further address the issues he pointed out.
> ---
> ?arch/arm/mach-pxa/irq.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index 858e287..d9cab3b 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -141,7 +141,7 @@ asmlinkage void __exception_irq_entry icip_handle_irq(struct pt_regs *regs)
> ? ? ? ? ? ? ? ?if (mask == 0)
> ? ? ? ? ? ? ? ? ? ? ? ?break;
>
> - ? ? ? ? ? ? ? asm_do_IRQ(fls(mask) - 1, regs);
> + ? ? ? ? ? ? ? asm_do_IRQ(PXA_IRQ(fls(mask) - 1), regs);
> ? ? ? ?} while (1);
> ?}
>
> --
> 1.7.4.4
>
>
prev parent reply other threads:[~2011-05-31 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 21:28 [PATCH] pxa: correct icip irq handling Dmitry Eremin-Solenikov
2011-05-31 5:31 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimG2bKvQ4u_Hq=dyJ56GL1Z4oBrug@mail.gmail.com' \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).