From: camhirundo@gmail.com (Hirundo Cam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] kirkwood: add dir-665 support
Date: Wed, 4 May 2011 10:36:04 +0800 [thread overview]
Message-ID: <BANLkTimQM_J2ZbDjAewUsp+XSEP+x+eniA@mail.gmail.com> (raw)
In-Reply-To: <20110503205056.GA13075@gentoodev.compulab.local>
Hi Mike,
2011/5/4 <mike@compulab.co.il>:
> Hello Hirundo Cam,
>
> I'm not Kirkwood expert, so my comments are quite general.
That's O.K.. It still helped other thing
> On Thu, Apr 28, 2011 at 12:34:46AM +0800, Hirundo Cam wrote:
>> This patch is a hack to dir-665 by referencing mv88f6281gtw_ge board.
>> LEDs, GPIO, Buttons remains unknown.
>>
>> To use this patch, u-boot must also be modified.
>>
>> Signed-off-by: Hirundo Cam <camhirundo@gmail.com>
>> ---
>> ?arch/arm/mach-kirkwood/Kconfig ? ? ? ? ? ?| ? ?6 ++
>> ?arch/arm/mach-kirkwood/Makefile ? ? ? ? ? | ? ?1 +
>> ?arch/arm/mach-kirkwood/mv88f6281_dir665.c | ?107 +++++++++++++++++++++++++++++
>> ?arch/arm/tools/mach-types ? ? ? ? ? ? ? ? | ? ?1 +
>> ?4 files changed, 115 insertions(+), 0 deletions(-)
>> ?create mode 100644 arch/arm/mach-kirkwood/mv88f6281_dir665.c
>>
>> diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig
>> index 7fc603b..296d97f 100644
>> --- a/arch/arm/mach-kirkwood/Kconfig
>> +++ b/arch/arm/mach-kirkwood/Kconfig
>> @@ -26,6 +26,12 @@ config MACH_MV88F6281GTW_GE
>> ? ? ? ? Say 'Y' here if you want your kernel to support the
>> ? ? ? ? Marvell 88F6281 GTW GE Board.
>>
>> +config MACH_MV88F6281_DIR665
>> + ? ? bool "Marvell 88F6281 DIR665 Board"
>> + ? ? help
>
> Citing checkpatch.pl:
> "WARNIING: please write a paragraph that describes the config symbol fully"
I've used checkpatch. and get this WARNING too.
But I didn't understand how the paragraph is wrong.
This section just as other sections. Should I add
this line "Say 'Y' here if you want your kernel to support the" into
th paragraph?
> Please check what headers are actually needed. I belieive that
> linux/input.h, linux/leds.h, linux/gpio.h and most probably many others
> can be safely removed.
Shouldn't I keep these stuff for future discovered LED and GPIOs?
> You should add the dir665 machine into the machine registry at
> http://www.arm.linux.org.uk/developer/machines/ rather than modify the
> mach-types file.
Thanks for your information.
Regards,
Hirundo Cam.
next prev parent reply other threads:[~2011-05-04 2:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 16:34 [PATCH] kirkwood: add dir-665 support Hirundo Cam
2011-04-27 23:52 ` Hirundo Cam
2011-05-03 15:55 ` Hirundo Cam
2011-05-03 20:51 ` mike at compulab.co.il
2011-05-04 2:36 ` Hirundo Cam [this message]
2011-05-04 2:54 ` Hirundo Cam
2011-05-04 3:00 ` Hirundo Cam
2011-05-04 6:32 ` Mike Rapoport
2011-05-04 8:09 ` Simon Guinot
2011-05-04 13:51 ` Nicolas Pitre
2011-05-05 0:23 ` Hirundo Cam
2011-05-05 15:06 ` Simon Guinot
2011-05-05 19:55 ` Nicolas Pitre
2011-05-06 15:41 ` Simon Guinot
2011-05-06 20:59 ` Nicolas Pitre
2011-05-04 3:30 ` Hirundo Cam
2011-05-04 6:31 ` Mike Rapoport
2011-05-03 21:14 ` Simon Guinot
[not found] ` <1304496346-13557-1-git-send-email-camhirundo@gmail.com>
2011-05-04 7:56 ` [PATCH v2] " Hirundo Cam
2011-05-04 8:16 ` Simon Guinot
2011-05-04 9:50 ` saeed bishara
2011-05-05 0:20 ` Hirundo Cam
2011-05-05 7:08 ` saeed bishara
2011-05-05 15:20 ` Hirundo Cam
2011-05-05 0:11 ` Hirundo Cam
2011-05-05 7:50 ` Simon Guinot
2011-05-04 9:23 ` [PATCH] " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimQM_J2ZbDjAewUsp+XSEP+x+eniA@mail.gmail.com \
--to=camhirundo@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).