* [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support
@ 2011-06-22 19:31 Paul Parsons
2011-06-22 19:44 ` Fabio Estevam
2012-02-26 10:55 ` Philipp Zabel
0 siblings, 2 replies; 5+ messages in thread
From: Paul Parsons @ 2011-06-22 19:31 UTC (permalink / raw)
To: linux-arm-kernel
Add LED support for the HTC ASIC3. Underlying support is provided by the mfd/asic3 and leds/leds-asic3 drivers. An example configuration is provided by the pxa/hx4700 platform.
Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
---
This part of the HTC ASIC3 LED driver patch set was seemingly dropped, hence repost.
--- clean-3.0-rc4/arch/arm/mach-pxa/hx4700.c 2011-06-21 04:25:46.000000000 +0100
+++ linux-3.0-rc4/arch/arm/mach-pxa/hx4700.c 2011-06-22 10:43:18.986382990 +0100
@@ -280,6 +280,21 @@ static u16 asic3_gpio_config[] = {
ASIC3_GPIOD15_nPIOW,
};
+static struct asic3_led asic3_leds[ASIC3_NUM_LEDS] = {
+ [0] = {
+ .name = "hx4700:amber",
+ .default_trigger = "ds2760-battery.0-charging-blink-full-solid",
+ },
+ [1] = {
+ .name = "hx4700:green",
+ .default_trigger = "unused",
+ },
+ [2] = {
+ .name = "hx4700:blue",
+ .default_trigger = "hx4700-radio",
+ },
+};
+
static struct resource asic3_resources[] = {
/* GPIO part */
[0] = {
@@ -310,6 +325,7 @@ static struct asic3_platform_data asic3_
.gpio_config_num = ARRAY_SIZE(asic3_gpio_config),
.irq_base = IRQ_BOARD_START,
.gpio_base = HX4700_ASIC3_GPIO_BASE,
+ .leds = asic3_leds,
};
static struct platform_device asic3 = {
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support
2011-06-22 19:31 [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support Paul Parsons
@ 2011-06-22 19:44 ` Fabio Estevam
2011-06-22 22:10 ` Fabio Estevam
2012-02-26 10:55 ` Philipp Zabel
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2011-06-22 19:44 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 22, 2011 at 4:31 PM, Paul Parsons <lost.distance@yahoo.com> wrote:
> Add LED support for the HTC ASIC3. Underlying support is provided by the mfd/asic3 and leds/leds-asic3 drivers. An example configuration is provided by the pxa/hx4700 platform.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> ---
>
> This part of the HTC ASIC3 LED driver patch set was seemingly dropped, hence repost.
>
> --- clean-3.0-rc4/arch/arm/mach-pxa/hx4700.c ? ?2011-06-21 04:25:46.000000000 +0100
> +++ linux-3.0-rc4/arch/arm/mach-pxa/hx4700.c ? ?2011-06-22 10:43:18.986382990 +0100
> @@ -280,6 +280,21 @@ static u16 asic3_gpio_config[] = {
> ? ? ? ?ASIC3_GPIOD15_nPIOW,
> ?};
>
> +static struct asic3_led asic3_leds[ASIC3_NUM_LEDS] = {
> + ? ? ? [0] = {
> + ? ? ? ? ? ? ? .name = "hx4700:amber",
> + ? ? ? ? ? ? ? .default_trigger = "ds2760-battery.0-charging-blink-full-solid",
> + ? ? ? },
> + ? ? ? [1] = {
> + ? ? ? ? ? ? ? .name = "hx4700:green",
> + ? ? ? ? ? ? ? .default_trigger = "unused",
> + ? ? ? },
> + ? ? ? [2] = {
> + ? ? ? ? ? ? ? .name = "hx4700:blue",
> + ? ? ? ? ? ? ? .default_trigger = "hx4700-radio",
> + ? ? ? },
> +};
Can't you use the generic LED driver instead? See an example here:
http://git.pengutronix.de/?p=imx/linux-2.6.git;a=commitdiff;h=cf1738dad02f22781ae1f08414634086fc613d81
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support
2011-06-22 19:44 ` Fabio Estevam
@ 2011-06-22 22:10 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2011-06-22 22:10 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 22, 2011 at 4:44 PM, Fabio Estevam <festevam@gmail.com> wrote:
..
> Can't you use the generic LED driver instead? See an example here:
> http://git.pengutronix.de/?p=imx/linux-2.6.git;a=commitdiff;h=cf1738dad02f22781ae1f08414634086fc613d81
Sorry, in your case it is not LED controlled via GPIO, so my previous
does not apply.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support
2011-06-22 19:31 [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support Paul Parsons
2011-06-22 19:44 ` Fabio Estevam
@ 2012-02-26 10:55 ` Philipp Zabel
2012-02-27 1:50 ` Haojian Zhuang
1 sibling, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2012-02-26 10:55 UTC (permalink / raw)
To: linux-arm-kernel
Am Mittwoch, den 22.06.2011, 19:31 +0000 schrieb Paul Parsons:
> Add LED support for the HTC ASIC3. Underlying support is provided by the mfd/asic3 and leds/leds-asic3 drivers. An example configuration is provided by the pxa/hx4700 platform.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> ---
>
> This part of the HTC ASIC3 LED driver patch set was seemingly dropped, hence repost.
>
> --- clean-3.0-rc4/arch/arm/mach-pxa/hx4700.c 2011-06-21 04:25:46.000000000 +0100
> +++ linux-3.0-rc4/arch/arm/mach-pxa/hx4700.c 2011-06-22 10:43:18.986382990 +0100
> @@ -280,6 +280,21 @@ static u16 asic3_gpio_config[] = {
> ASIC3_GPIOD15_nPIOW,
> };
>
> +static struct asic3_led asic3_leds[ASIC3_NUM_LEDS] = {
> + [0] = {
> + .name = "hx4700:amber",
> + .default_trigger = "ds2760-battery.0-charging-blink-full-solid",
> + },
> + [1] = {
> + .name = "hx4700:green",
> + .default_trigger = "unused",
> + },
> + [2] = {
> + .name = "hx4700:blue",
> + .default_trigger = "hx4700-radio",
> + },
> +};
> +
> static struct resource asic3_resources[] = {
> /* GPIO part */
> [0] = {
> @@ -310,6 +325,7 @@ static struct asic3_platform_data asic3_
> .gpio_config_num = ARRAY_SIZE(asic3_gpio_config),
> .irq_base = IRQ_BOARD_START,
> .gpio_base = HX4700_ASIC3_GPIO_BASE,
> + .leds = asic3_leds,
> };
>
> static struct platform_device asic3 = {
>
Acked-by: Philipp Zabel <philipp.zabel@gmail.com>
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support
2012-02-26 10:55 ` Philipp Zabel
@ 2012-02-27 1:50 ` Haojian Zhuang
0 siblings, 0 replies; 5+ messages in thread
From: Haojian Zhuang @ 2012-02-27 1:50 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Feb 26, 2012 at 6:55 PM, Philipp Zabel <philipp.zabel@gmail.com> wrote:
> Am Mittwoch, den 22.06.2011, 19:31 +0000 schrieb Paul Parsons:
>> Add LED support for the HTC ASIC3. Underlying support is provided by the mfd/asic3 and leds/leds-asic3 drivers. An example configuration is provided by the pxa/hx4700 platform.
>>
>> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
>> ---
>>
>> This part of the HTC ASIC3 LED driver patch set was seemingly dropped, hence repost.
>>
>> --- clean-3.0-rc4/arch/arm/mach-pxa/hx4700.c ?2011-06-21 04:25:46.000000000 +0100
>> +++ linux-3.0-rc4/arch/arm/mach-pxa/hx4700.c ?2011-06-22 10:43:18.986382990 +0100
>> @@ -280,6 +280,21 @@ static u16 asic3_gpio_config[] = {
>> ? ? ? ASIC3_GPIOD15_nPIOW,
>> ?};
>>
>> +static struct asic3_led asic3_leds[ASIC3_NUM_LEDS] = {
>> + ? ? [0] = {
>> + ? ? ? ? ? ? .name = "hx4700:amber",
>> + ? ? ? ? ? ? .default_trigger = "ds2760-battery.0-charging-blink-full-solid",
>> + ? ? },
>> + ? ? [1] = {
>> + ? ? ? ? ? ? .name = "hx4700:green",
>> + ? ? ? ? ? ? .default_trigger = "unused",
>> + ? ? },
>> + ? ? [2] = {
>> + ? ? ? ? ? ? .name = "hx4700:blue",
>> + ? ? ? ? ? ? .default_trigger = "hx4700-radio",
>> + ? ? },
>> +};
>> +
>> ?static struct resource asic3_resources[] = {
>> ? ? ? /* GPIO part */
>> ? ? ? [0] = {
>> @@ -310,6 +325,7 @@ static struct asic3_platform_data asic3_
>> ? ? ? .gpio_config_num = ARRAY_SIZE(asic3_gpio_config),
>> ? ? ? .irq_base ? ? ? ?= IRQ_BOARD_START,
>> ? ? ? .gpio_base ? ? ? = HX4700_ASIC3_GPIO_BASE,
>> + ? ? .leds ? ? ? ? ? ?= asic3_leds,
>> ?};
>>
>> ?static struct platform_device asic3 = {
>>
>
> Acked-by: Philipp Zabel <philipp.zabel@gmail.com>
>
> regards
> Philipp
>
Applied.
Thanks
Haojian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-27 1:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-22 19:31 [PATCH REPOST] pxa/hx4700: Add ASIC3 LED support Paul Parsons
2011-06-22 19:44 ` Fabio Estevam
2011-06-22 22:10 ` Fabio Estevam
2012-02-26 10:55 ` Philipp Zabel
2012-02-27 1:50 ` Haojian Zhuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).