From: viliam.mateicka@gmail.com (Viliam Mateicka)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] s3c2410_udc: fix custom UDC command handling
Date: Mon, 20 Jun 2011 10:25:51 +0200 [thread overview]
Message-ID: <BANLkTimWM2oew2f9uWxoD1kw1=2bSYFFuw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTin2w5muF+LV269DV1=L+_j8P6DT_Q@mail.gmail.com>
So, will somebody at least react/reply (or just fix) ?
Vilo
On Thu, Jun 16, 2011 at 10:04 AM, Viliam Mateicka
<viliam.mateicka@gmail.com> wrote:
> There is a bug in Samsung's UDC driver, which is completely disabling
> the USB device when a custom UDC command is used.
> Following patch seems to get the right?behavior (e.g. enabling pull-up
> instead of disabling then Vcc is applied). Also I'm not in mailing
> list so please CC me.
>
> Greetingz,
> Vilo
>
> Signed-off-by: Viliam Mateicka <viliam.mateicka@gmail.com>
>
> --- drivers/usb/gadget/s3c2410_udc.c.orig ? ? ? 2011-05-19
> 06:06:34.000000000 +0200
> +++ drivers/usb/gadget/s3c2410_udc.c ? ?2011-06-16 08:57:19.000000000 +0200
> @@ -1566,7 +1566,7 @@ static void s3c2410_udc_command(enum s3c
> ? ? ? ? ? ? ? ? return;
> ? ? ? ? if (udc_info->udc_command) {
> - ? ? ? ? ? ? ? udc_info->udc_command(S3C2410_UDC_P_DISABLE);
> + ? ? ? ? ? ? ? udc_info->udc_command(cmd);
> ? ? ? ? } else if (gpio_is_valid(udc_info->pullup_pin)) {
> ? ? ? ? ? ? ? ? int value;
>
next prev parent reply other threads:[~2011-06-20 8:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 8:04 [PATCH] s3c2410_udc: fix custom UDC command handling Viliam Mateicka
2011-06-20 8:25 ` Viliam Mateicka [this message]
2011-06-20 15:07 ` Alan Stern
2011-06-20 15:15 ` Felipe Balbi
2011-06-20 15:20 ` Skacore Systems
2011-06-20 15:36 ` Felipe Balbi
2011-06-20 15:48 ` Skacore Systems
2011-06-20 15:57 ` Skacore Systems
2011-06-20 16:06 ` Felipe Balbi
2011-06-20 16:41 ` Skacore Systems
2011-06-20 17:05 ` Felipe Balbi
2011-06-20 17:27 ` Viliam Mateicka
2011-06-20 17:34 ` Felipe Balbi
2011-06-20 19:05 ` Viliam Mateicka
2011-06-20 16:07 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimWM2oew2f9uWxoD1kw1=2bSYFFuw@mail.gmail.com' \
--to=viliam.mateicka@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).