linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] serial/imx: add device tree support
Date: Thu, 23 Jun 2011 22:05:00 -0600	[thread overview]
Message-ID: <BANLkTimXZvW16uMRGMeyH203e6MHxdNbSA@mail.gmail.com> (raw)
In-Reply-To: <20110624034859.GB19188@S2100-06.ap.freescale.net>

On Thu, Jun 23, 2011 at 9:49 PM, Shawn Guo <shawn.guo@freescale.com> wrote:
> On Thu, Jun 23, 2011 at 05:11:54PM -0600, Grant Likely wrote:
>> > + ? ? ? ? ? ? ? int devid = get_alias_name_id(pp->name, devname);
>> > +
>> > + ? ? ? ? ? ? ? /* We do not want to proceed this sentinel one */
>> > + ? ? ? ? ? ? ? if (!strcmp(pp->name, "name") && !strcmp(pp->value, "aliases"))
>> > + ? ? ? ? ? ? ? ? ? ? ? break;
>>
>> Skipping the 'name' property is good, but I don't think you need to
>> check the value. ?You should also skip the "phandle" property.
>>
> Ok. I have not seen "phandle" property in aliases node though. ?Can
> you give me an example, so that I can make one up for testing?

It's a standard property that shows up automatically if any node
happens to have a phandle reference to another node.  The name will be
either "phandle" or "linux,phandle".  Search for "linux,phandle" in
drivers/of/fdt.c to see how that property is processed.

g.

  reply	other threads:[~2011-06-24  4:05 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-18 15:19 [PATCH 0/3] Add basic device support for imx51 babbage Shawn Guo
2011-06-18 15:19 ` [PATCH 1/3] serial/imx: add device tree support Shawn Guo
2011-06-18 16:19   ` Grant Likely
2011-06-19  7:02     ` Wolfram Sang
2011-06-19  7:30     ` Shawn Guo
2011-06-19 15:05       ` Grant Likely
2011-06-19 15:15         ` Rob Herring
2011-06-19 18:44           ` Grant Likely
2011-06-21 13:55       ` Shawn Guo
2011-06-21 18:32         ` Mitch Bradley
2011-06-21 18:42           ` Grant Likely
2011-06-21 18:53             ` Russell King - ARM Linux
2011-06-21 19:02               ` Grant Likely
2011-06-21 19:04             ` Mitch Bradley
2011-06-21 19:13         ` Grant Likely
2011-06-21 19:35           ` Mitch Bradley
2011-06-21 19:38             ` Grant Likely
2011-06-21 22:08               ` Mitch Bradley
2011-06-21 22:33                 ` Grant Likely
2011-06-21 22:52                   ` Segher Boessenkool
2011-06-21 22:58                     ` Grant Likely
2011-06-22 15:33           ` Shawn Guo
2011-06-22 15:52             ` Grant Likely
2011-06-23  0:12               ` Shawn Guo
2011-06-23  3:35                 ` Grant Likely
2011-06-23 18:38           ` Shawn Guo
2011-06-23 23:11             ` Grant Likely
2011-06-24  3:49               ` Shawn Guo
2011-06-24  4:05                 ` Grant Likely [this message]
2011-06-18 16:21   ` Arnd Bergmann
2011-06-18 16:26     ` Grant Likely
2011-06-18 18:11       ` Arnd Bergmann
2011-06-19  7:41       ` Shawn Guo
2011-06-19  7:40     ` Shawn Guo
2011-06-18 15:19 ` [PATCH 2/3] net/fec: " Shawn Guo
2011-06-18 16:22   ` Grant Likely
2011-06-19  7:46     ` Shawn Guo
2011-06-18 18:27   ` Arnd Bergmann
2011-06-19  0:24     ` Grant Likely
2011-06-19  7:55     ` Shawn Guo
2011-06-19 11:39   ` Greg Ungerer
2011-06-19 12:11     ` Arnd Bergmann
2011-06-19 15:09       ` Rob Herring
2011-06-19 18:43         ` Grant Likely
2011-06-20  0:05       ` Greg Ungerer
2011-06-18 15:19 ` [PATCH 3/3] ARM: mx5: add basic device tree support for imx51 babbage Shawn Guo
2011-06-18 16:24   ` Grant Likely
2011-06-18 16:29 ` [PATCH 0/3] Add basic device " Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimXZvW16uMRGMeyH203e6MHxdNbSA@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).