From mboxrd@z Thu Jan  1 00:00:00 1970
From: philipp.zabel@gmail.com (pHilipp Zabel)
Date: Fri, 22 Apr 2011 12:35:20 +0200
Subject: [PATCH] pxa/mioa701: use gpio arrays for global and gsm gpio
	initialization
In-Reply-To: <87tydre1c7.fsf@free.fr>
References: <1303329331.21545.7.camel@flow>
	<87tydre1c7.fsf@free.fr>
Message-ID: <BANLkTimXsD6BYa2PPXmrY=aABLNFSRW4Sw@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, Apr 21, 2011 at 11:33 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Philipp Zabel <philipp.zabel@gmail.com> writes:
>
>> gpio_request_arrays() / gpio_free_arrays() are functional replacements for
>> mio_gpio_request() / mio_gpio_free(), which are now obsolete.
>>
>> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Dmitry Artamonow pointed out that contrary to
hx4700/mio_gpio_request(), gpio_request_array() is silent when a
request fails. Would you prefer something like

int rc;
rc = gpio_request_array(ARRAY_AND_SIZE(global_gpios));
if (rc)
    pr_err("MioA701: Failed to request GPIOs.\n");

in there?

regards
Philipp