From: per.forlin@linaro.org (Per Forlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req
Date: Thu, 21 Apr 2011 11:47:19 +0200 [thread overview]
Message-ID: <BANLkTim_5fsJ06CTgxAvPjrb8y5FpW=xRg@mail.gmail.com> (raw)
In-Reply-To: <20110421091115.GH4024@S2100-06.ap.freescale.net>
On 21 April 2011 11:11, Shawn Guo <shawn.guo@freescale.com> wrote:
> On Thu, Apr 21, 2011 at 10:46:18AM +0200, Per Forlin wrote:
>> On 21 April 2011 08:29, Shawn Guo <shawn.guo@freescale.com> wrote:
>> > On Wed, Apr 20, 2011 at 05:30:22PM +0200, Per Forlin wrote:
>> > [...]
>> >> Remove dma_map and dma_unmap from your host driver and run the tests
>> >> (obviously nonblocking and blocking will have the same results). If
>> >> there is still no performance gain the cache penalty is very small on
>> >> your platform and therefore nonblocking doesn't improve things much.
>> >> Please let me know the result.
>> >>
>> > Sorry, I could not understand. ?What's the point to run the test when
>> > the driver is even broken. ?The removal of ?dma_map_sg and
>> > dma_unmap_sg makes mxs-mmc host driver broken.
>> The point is only to get a measurement of the cost of handling
>> dma_map_sg and dma_unmap_sg, this is the maximum time mmc nonblocking
>> can save.
>> The nonblocking mmc_test should save the total time of dma_map_sg and
>> dma_unmap_sg, if the pre_req and post_req hooks are implemented
>> correctly.
>> Running without dma_map_sg and dma_unmap_sg will confirm if the
>> pre_req and post_req hooks are implemented correctly.
>>
> With dma_map_sg and dma_unmap_sg removed, the mmc_test gave very low
> numbers, though blocking and non-blocking numbers are same. ?Is it
> an indication that pre_req and post_req hooks are not implemented
> correctly?
I think you could get the same numbers for the nonblocking with
dma_map and dma_unmap in place.
> ?If yes, can you please help to catch the mistakes?
I will take a look.
> --
> Regards,
> Shawn
>
>
Regards,
Per
next prev parent reply other threads:[~2011-04-21 9:47 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 19:07 [PATCH v2 00/12] mmc: use nonblock mmc requests to minimize latency Per Forlin
2011-04-06 19:07 ` [PATCH v2 01/12] mmc: add none blocking mmc request function Per Forlin
2011-04-15 10:34 ` David Vrabel
2011-04-20 7:17 ` Per Forlin
2011-04-26 13:29 ` David Vrabel
2011-04-26 14:22 ` Per Forlin
2011-04-06 19:07 ` [PATCH v2 02/12] mmc: mmc_test: add debugfs file to list all tests Per Forlin
2011-04-06 19:07 ` [PATCH v2 03/12] mmc: mmc_test: add test for none blocking transfers Per Forlin
2011-04-17 7:09 ` Lin Tony-B19295
2011-04-20 7:30 ` Per Forlin
2011-04-17 15:46 ` Shawn Guo
2011-04-20 7:41 ` Per Forlin
2011-04-06 19:07 ` [PATCH v2 04/12] mmc: add member in mmc queue struct to hold request data Per Forlin
2011-04-06 19:07 ` [PATCH v2 05/12] mmc: add a block request prepare function Per Forlin
2011-04-06 19:07 ` [PATCH v2 06/12] mmc: move error code in mmc_block_issue_rw_rq to a separate function Per Forlin
2011-04-06 19:07 ` [PATCH v2 07/12] mmc: add a second mmc queue request member Per Forlin
2011-04-06 19:07 ` [PATCH v2 08/12] mmc: add handling for two parallel block requests in issue_rw_rq Per Forlin
2011-04-20 11:32 ` Per Forlin
2011-04-06 19:07 ` [PATCH v2 09/12] mmc: test: add random fault injection in core.c Per Forlin
2011-04-06 19:07 ` [PATCH v2 10/12] omap_hsmmc: use original sg_len for dma_unmap_sg Per Forlin
2011-04-06 19:07 ` [PATCH v2 11/12] omap_hsmmc: add support for pre_req and post_req Per Forlin
2011-04-06 19:07 ` [PATCH v2 12/12] mmci: implement pre_req() and post_req() Per Forlin
2011-04-08 16:49 ` [PATCH v2 00/12] mmc: use nonblock mmc requests to minimize latency Linus Walleij
2011-04-09 11:55 ` Jae hoon Chung
2011-04-10 3:33 ` anish singh
2011-04-11 9:03 ` Per Forlin
2011-04-11 9:07 ` Sachin Nikam
2011-04-11 9:08 ` Per Forlin
2011-04-19 14:30 ` Jae hoon Chung
2011-04-16 15:48 ` Shawn Guo
2011-04-20 8:19 ` Per Forlin
2011-04-16 16:48 ` [PATCH] mmc: sdhci: add support for pre_req and post_req Shawn Guo
2011-04-16 23:06 ` Andrei Warkentin
2011-04-22 11:01 ` Jaehoon Chung
2011-04-27 0:59 ` Andrei Warkentin
2011-04-26 1:26 ` Jaehoon Chung
2011-04-26 2:47 ` Shawn Guo
2011-04-26 10:21 ` Per Forlin
2011-04-17 16:33 ` [PATCH] mmc: mxs-mmc: " Shawn Guo
2011-04-17 16:48 ` Shawn Guo
2011-04-20 8:01 ` Per Forlin
2011-04-20 14:01 ` Shawn Guo
2011-04-20 15:22 ` Per Forlin
2011-04-21 6:25 ` Shawn Guo
2011-04-21 8:52 ` Per Forlin
2011-04-20 15:30 ` Per Forlin
2011-04-21 6:29 ` Shawn Guo
2011-04-21 8:46 ` Per Forlin
2011-04-21 9:11 ` Shawn Guo
2011-04-21 9:47 ` Per Forlin [this message]
2011-04-21 10:15 ` Per Forlin
2011-04-28 7:52 ` Per Forlin
2011-04-28 10:10 ` Russell King - ARM Linux
2011-04-20 7:58 ` Per Forlin
2011-04-20 8:17 ` Shawn Guo
2011-04-20 13:51 ` [PATCH v2] " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTim_5fsJ06CTgxAvPjrb8y5FpW=xRg@mail.gmail.com' \
--to=per.forlin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).