linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: per.forlin@linaro.org (Per Forlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] sdio: report error if pending IRQ but none function bits
Date: Tue, 7 Jun 2011 09:02:58 +0200	[thread overview]
Message-ID: <BANLkTimhzdAoXSCD0xfGwOMDE9+gbrt53A@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1106011029390.30544@xanadu.home>

On 1 June 2011 16:30, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> On Tue, 31 May 2011, Per Forlin wrote:
>
>> Return error in case of pending IRQ but none functions bits
>> in CCCR_INTx is set.
>>
>> Signed-off-by: Per Forlin <per.forlin@linaro.org>
>> ---
>> ?drivers/mmc/core/sdio_irq.c | ? ?5 +++++
>> ?1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
>> index 2f81ddc..8184b6e 100644
>> --- a/drivers/mmc/core/sdio_irq.c
>> +++ b/drivers/mmc/core/sdio_irq.c
>> @@ -50,6 +50,11 @@ static int process_sdio_pending_irqs(struct mmc_card *card)
>> ? ? ? ? ? ? ? return ret;
>> ? ? ? }
>>
>> + ? ? if (!pending) {
>> + ? ? ? ? ? ? printk(KERN_WARNING "%s: pending IRQ but none function bits\n",
>> + ? ? ? ? ? ? ? ? ? ?mmc_card_id(card));
>> + ? ? ? ? ? ? ret = -EINVAL;
>> + ? ? }
>
> Nope, this won't work with the polled interrupt mode.
I'll drop this patch.

Thanks for your comment,
Per

  reply	other threads:[~2011-06-07  7:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 20:33 [PATCH 0/2] sdio: make sdio_single_irq optional due to suprious IRQ Per Forlin
2011-05-31 20:33 ` [PATCH 1/2] sdio: add function to enable and disable sdio_single_irq optimization Per Forlin
2011-06-01  7:30   ` Linus Walleij
2011-06-01  7:39     ` Per Forlin
2011-05-31 20:33 ` [PATCH 2/2] sdio: report error if pending IRQ but none function bits Per Forlin
2011-06-01 14:30   ` Nicolas Pitre
2011-06-07  7:02     ` Per Forlin [this message]
2011-05-31 21:52 ` [PATCH 0/2] sdio: make sdio_single_irq optional due to suprious IRQ Daniel Drake
2011-06-01 14:29   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimhzdAoXSCD0xfGwOMDE9+gbrt53A@mail.gmail.com \
    --to=per.forlin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).