From mboxrd@z Thu Jan 1 00:00:00 1970 From: per.forlin@linaro.org (Per Forlin) Date: Tue, 7 Jun 2011 09:02:58 +0200 Subject: [PATCH 2/2] sdio: report error if pending IRQ but none function bits In-Reply-To: References: <1306874008-28867-1-git-send-email-per.forlin@linaro.org> <1306874008-28867-3-git-send-email-per.forlin@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 1 June 2011 16:30, Nicolas Pitre wrote: > On Tue, 31 May 2011, Per Forlin wrote: > >> Return error in case of pending IRQ but none functions bits >> in CCCR_INTx is set. >> >> Signed-off-by: Per Forlin >> --- >> ?drivers/mmc/core/sdio_irq.c | ? ?5 +++++ >> ?1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c >> index 2f81ddc..8184b6e 100644 >> --- a/drivers/mmc/core/sdio_irq.c >> +++ b/drivers/mmc/core/sdio_irq.c >> @@ -50,6 +50,11 @@ static int process_sdio_pending_irqs(struct mmc_card *card) >> ? ? ? ? ? ? ? return ret; >> ? ? ? } >> >> + ? ? if (!pending) { >> + ? ? ? ? ? ? printk(KERN_WARNING "%s: pending IRQ but none function bits\n", >> + ? ? ? ? ? ? ? ? ? ?mmc_card_id(card)); >> + ? ? ? ? ? ? ret = -EINVAL; >> + ? ? } > > Nope, this won't work with the polled interrupt mode. I'll drop this patch. Thanks for your comment, Per