From: vitalivanov@gmail.com (Vitaliy Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][Trivial] S3C2410 bluetooth: Remove duplicate linux/leds.h include
Date: Mon, 20 Jun 2011 12:32:49 +0300 [thread overview]
Message-ID: <BANLkTimjoiDxDX-_Qg4U6TSW6jjEa5xSsw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1106201035590.18991@swampdragon.chaosbits.net>
Jusper/Linus/All,
On Mon, Jun 20, 2011 at 11:40 AM, Jesper Juhl <jj@chaosbits.net> wrote:
> Remove the duplicate inclusion of linux/leds.h from
> arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> ?h1940-bluetooth.c | ? ?1 -
> ?1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-s3c2410/h1940-bluetooth.c b/arch/arm/mach-s3c2410/h1940-bluetooth.c
> index 2c126bb..a5eeb62 100644
> --- a/arch/arm/mach-s3c2410/h1940-bluetooth.c
> +++ b/arch/arm/mach-s3c2410/h1940-bluetooth.c
> @@ -18,7 +18,6 @@
> ?#include <linux/leds.h>
> ?#include <linux/gpio.h>
> ?#include <linux/rfkill.h>
> -#include <linux/leds.h>
>
> ?#include <mach/regs-gpio.h>
> ?#include <mach/hardware.h>
>
> --
Some time ago I already sent a patch to handle all the headers
duplication corrections. Please check this:
https://lkml.org/lkml/2011/6/16/301
It should handle all the cases you described at:
https://lkml.org/lkml/2011/6/20/72
https://lkml.org/lkml/2011/6/20/78
https://lkml.org/lkml/2011/6/20/75
I didn't receive any comments and still can see that it's not in
mainline Linus' tree.
Thanks,
Vitaliy
next prev parent reply other threads:[~2011-06-20 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 8:40 [PATCH][Trivial] S3C2410 bluetooth: Remove duplicate linux/leds.h include Jesper Juhl
2011-06-20 9:32 ` Vitaliy Ivanov [this message]
2011-06-20 10:50 ` Jesper Juhl
2011-06-20 10:02 ` Sergei Shtylyov
2011-06-20 10:34 ` Jesper Juhl
2011-06-20 10:49 ` Vitaliy Ivanov
2011-06-20 14:09 ` Jiri Kosina
2011-06-20 16:44 ` Vitaliy Ivanov
2011-06-20 11:16 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimjoiDxDX-_Qg4U6TSW6jjEa5xSsw@mail.gmail.com \
--to=vitalivanov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).