linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma
Date: Wed, 8 Jun 2011 08:21:08 +0530	[thread overview]
Message-ID: <BANLkTimwAHdpJbLqqBwEXjqWwg75SciUVw@mail.gmail.com> (raw)
In-Reply-To: <20110607214151.GA7712@opensource.wolfsonmicro.com>

On Wed, Jun 8, 2011 at 3:11 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Jun 08, 2011 at 12:31:42AM +0530, Jassi Brar wrote:
>> On Wed, Jun 8, 2011 at 12:13 AM, Mark Brown
>
>> > Circular buffers are nice from the point of view of allowing you to
>> > (providing the hardware supports it) totally disable the periodic audio
>> > interrupts and leave the system to run for very long times off the
>
>> This is what I called free-running circular buffer.
>> Besides power saving scenario, it is necessary for a fast peripheral
>> with shallow fifo.
>> The peripheral throws underrun errors, if the dma h/w doesn't support
>> LLI and cpu takes
>> a bit long loading-triggering the next transfer on DMA due to
>> irq-latency for some reason.
>
> That's fairly unusual, though - usually DMA controllers seem to support
> chaining requests before they support circular operation, at which point
> unless the hardware is badly misdone you can just chain another buffer,
> giving that buffer's worth of time for the CPU to respond.

While writing PL330 driver, I wasn't able to figure out a way to implement LLI.
Please have a look at the PL330 trm and suggest if we can implement it in a
generic way without considering them special requests.
I know pl080 supports LLI and it's fine.


>> > You can also do this with an circular chain of sequential buffers of
>> > course.
>
>> This is what is called Circular buffer in Samsung's DMA API.
>
> Which is a little bit unusual as it's basically a pure software
> construct rather than a hardware feature.
Yes it is. And I didn't say it suffice.

  reply	other threads:[~2011-06-08  2:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07  7:48 [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma root
2011-06-07  8:00 ` Kyungmin Park
2011-06-07  8:09   ` Jassi Brar
2011-06-07  8:15     ` Russell King - ARM Linux
2011-06-07  8:35       ` Kyungmin Park
2011-06-07 10:15       ` Jassi Brar
2011-06-07 18:29         ` Russell King - ARM Linux
2011-06-07 18:43           ` Mark Brown
2011-06-07 19:01             ` Jassi Brar
2011-06-07 21:41               ` Mark Brown
2011-06-08  2:51                 ` Jassi Brar [this message]
2011-06-08  8:55                   ` Mark Brown
2011-06-07 22:28               ` Russell King - ARM Linux
2011-06-08  4:05                 ` Jassi Brar
2011-06-08  7:44                   ` Russell King - ARM Linux
2011-06-07 19:46           ` Jassi Brar
2011-06-07 22:36             ` Russell King - ARM Linux
2011-06-09 18:24               ` Kukjin Kim
2011-06-16 12:56                 ` Kyungmin Park
2011-06-23  6:47                   ` Kukjin Kim
2011-06-07 10:15     ` Linus Walleij
2011-06-07 10:05       ` Koul, Vinod
2011-06-07  8:01 ` Jassi Brar
2011-06-07 15:42 ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimwAHdpJbLqqBwEXjqWwg75SciUVw@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).