From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] dmaengine: add ep93xx DMA support
Date: Wed, 25 May 2011 22:47:14 +0200 [thread overview]
Message-ID: <BANLkTin8Trn-44Op+GbxrgocFrnPuXUZ2w@mail.gmail.com> (raw)
In-Reply-To: <20110525195413.GC2996@acer>
2011/5/25 Mika Westerberg <mika.westerberg@iki.fi>:
> I re-checked the specs and indeed, as discussed previously, it is clear that
> Cirrus (or ARM) copied the interface from other. Even the wording in the
> document is identical in many places. However, in ep93xx User's Guide, there
> is no mention about SSP being AMBA PrimeCell peripheral. For UARTs it is
> mentioned... go figure.
>
> There are differences also, some of the bits in control registers are in
> different places. Interrupt registers are completely different and there is no
> DMA control register at all. The same things we discussed before.
But it really does not matter. The amba-pl022.c driver has all the same
deviations for things called "PL023" that are not pure PL022 either.
I just made the driver a bit more flexible, supporting both.
If the people doing drivers/usb/musb/* had done the same thing we
would have had what, 5 drivers for similar hardware?
> Back then, it wasn't known how the M2M DMA interface (the one used
> by SSP and IDE) was going to be implemented.
But I knew, having just written the needed extensions to dmaengine.
And I said so. But I realize I'm maybe not considered an authoritative
source on the subject, and I'm biased.
> IMHO it is better to have ep93xx implementation on its own driver since it is
> not a real AMBA PL022 peripheral but some weird hack made by Cirrus (although
> my opinions are bit biased).
I disagree because it's IMO at first sight no more deviant than our "PL023"
variants that still use the same pl022 driver.
Is there some inexepensive hardware with EP93xx I can get to fix this
myself?
Yours,
Linus Walleij
next prev parent reply other threads:[~2011-05-25 20:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 17:03 [PATCH 0/5] ep93xx DMA patches Mika Westerberg
2011-05-22 17:03 ` [PATCH 1/5] dmaengine: add ep93xx DMA support Mika Westerberg
2011-05-25 8:00 ` Koul, Vinod
2011-05-25 19:00 ` Mika Westerberg
2011-05-26 4:38 ` Koul, Vinod
2011-05-26 18:15 ` Mika Westerberg
2011-05-26 18:42 ` H Hartley Sweeten
2011-05-25 8:39 ` Linus Walleij
2011-05-25 8:19 ` Koul, Vinod
2011-05-25 9:09 ` Linus Walleij
2011-05-25 19:54 ` Mika Westerberg
2011-05-25 20:47 ` Linus Walleij [this message]
2011-05-26 4:33 ` Mika Westerberg
2011-05-26 5:26 ` Ryan Mallon
2011-05-26 7:15 ` Linus Walleij
2011-05-26 18:38 ` Mika Westerberg
2011-05-26 18:48 ` H Hartley Sweeten
2011-05-26 21:53 ` Russell King - ARM Linux
2011-05-26 22:58 ` Linus Walleij
2011-05-27 1:38 ` H Hartley Sweeten
2011-05-28 10:33 ` Mika Westerberg
2011-05-22 17:03 ` [PATCH 2/5] ep93xx: add dmaengine platform code Mika Westerberg
2011-05-27 1:44 ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 3/5] ASoC: ep93xx: convert to use the DMA engine API Mika Westerberg
2011-05-23 5:11 ` Mark Brown
2011-05-23 9:38 ` Liam Girdwood
2011-05-27 1:43 ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 4/5] ep93xx: remove the old M2P DMA code Mika Westerberg
2011-05-27 1:42 ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 5/5] spi/ep93xx: add DMA support Mika Westerberg
2011-05-27 1:47 ` H Hartley Sweeten
2011-05-23 17:34 ` [PATCH 0/5] ep93xx DMA patches H Hartley Sweeten
2011-05-23 20:10 ` Ryan Mallon
2011-05-24 14:42 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin8Trn-44Op+GbxrgocFrnPuXUZ2w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).