linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] Extending ARM perf-events for multiple PMUs
Date: Fri, 8 Apr 2011 20:10:04 +0200	[thread overview]
Message-ID: <BANLkTinAcAudWKvipYVLyijUrLZVFozBWQ@mail.gmail.com> (raw)
In-Reply-To: <1302282912.5758.25.camel@e102144-lin.cambridge.arm.com>

Hi Will, thanks for this quite informative letter!

On Fri, Apr 8, 2011 at 7:15 PM, Will Deacon <will.deacon@arm.com> wrote:

> Implementing support for Counting System PMUs can reuse a lot of the
> functionality in perf_event.c (for example, struct arm_pmu) but the low-level
> accessors should be separate and a new struct pmu should be used. This means
> that we will want multiple instances of struct arm_pmu and a method to translate
> from a struct pmu to a struct arm_pmu. We'll also need to clean up some of the
> armpmu_* functions to ensure the correction indirection is used when invoking
> per-pmu functions.

What I start wondering at this point in the description is that there is some
implicit assumption that counting system PMU:s is an arch/arm/* thing,
that they should even be named arm_* and I guess as such they are
some PrimeCell kind of thing.

I can surely accept the per-CPU close-to-CPU counters to live
in arch/arm/* but..

I am thinking that a SoC vendor like Renesas may be implementing a
System PMU monitoring a bus shared between an SH and and ARM
core.

Unless you're ARM Ltd you can also think about vendors doing System
PMU IP blocks and synthesizing these in both ARM and other-arch
systems.

So maybe this needs an multiarch-spanning solution? I start
thinking about decoupling these babies from the arch and abstracting
them into something like drivers/perf

Am I totally misguided in this?

Yours,
Linus Walleij

  reply	other threads:[~2011-04-08 18:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 17:15 [RFC] Extending ARM perf-events for multiple PMUs Will Deacon
2011-04-08 18:10 ` Linus Walleij [this message]
2011-04-11 11:12   ` Will Deacon
2011-04-09 11:40 ` Peter Zijlstra
2011-04-11 11:29   ` Will Deacon
2011-04-11 12:47     ` Peter Zijlstra
2011-04-11 17:44     ` Ashwin Chaugule
2011-04-12 17:45       ` Will Deacon
2011-04-11 18:00   ` Ashwin Chaugule
2011-04-12  7:39   ` Ming Lei
2011-04-12 10:30     ` Peter Zijlstra
2011-04-12 11:12       ` Ming Lei
2011-04-11 17:29 ` Ashwin Chaugule
2011-04-11 18:00   ` Will Deacon
2011-04-11 20:46     ` Ashwin Chaugule
2011-04-12 18:08       ` Will Deacon
2011-04-13  5:09         ` Ashwin Chaugule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinAcAudWKvipYVLyijUrLZVFozBWQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).