From: jean.pihet@newoldbits.com (Jean Pihet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] OMAP3: cpuidle: change the power domains modes determination logic
Date: Fri, 29 Apr 2011 16:00:40 +0200 [thread overview]
Message-ID: <BANLkTinEwUukmE2LP6F3q_8KDBHvdRqkVA@mail.gmail.com> (raw)
In-Reply-To: <4DBAA12D.6070203@ti.com>
Hi Santosh,
On Fri, Apr 29, 2011 at 1:29 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> On 4/29/2011 2:56 PM, jean.pihet at newoldbits.com wrote:
>>
>> From: Jean Pihet<j-pihet@ti.com>
>>
>> The achievable power modes of the power domains in cpuidle
>> depends on the system wide 'enable_off_mode' knob in debugfs.
>> Upon changing enable_off_mode, do not change the C-states
>> 'valid' field but instead dynamically restrict the power modes
>> when entering idle.
>>
>> The C-states 'valid' field is just used to enable/disable some
>> C-states at init and shall not be changed later on.
>>
>> Signed-off-by: Jean Pihet<j-pihet@ti.com>
...
> Since you have started clean-up, we should get rid of the
> "enable_off_mode" some how. I got that done for OMAP4 using
> prepare() hook and IGNORE flag as per Kevin's suggestion
> but unfortunately its seems to getting removed from
> core cpuidle code.
The idea is to remove the enable_off_mode knob from debugfs and
instead have the devices constraints API control the power domains
behavior.
Cf. PATCH 0/5 of this series for some remarks about further clean-up work.
Thanks!
Jean
>
> Regards
> Santosh
>
prev parent reply other threads:[~2011-04-29 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 9:26 [PATCH 0/5] OMAP: cpuidle code clean-up jean.pihet at newoldbits.com
2011-04-29 9:26 ` [PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings jean.pihet at newoldbits.com
2011-04-29 11:14 ` Santosh Shilimkar
2011-05-04 14:40 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 2/5] OMAP3: clean-up mach specific cpuidle data structures jean.pihet at newoldbits.com
2011-05-04 20:09 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 3/5] OMAP3: cpuidle: re-organize the C-states data jean.pihet at newoldbits.com
2011-04-29 11:24 ` Santosh Shilimkar
2011-05-04 14:59 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 4/5] OMAP3: cpuidle: code rework for improved readability jean.pihet at newoldbits.com
2011-05-04 15:32 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 5/5] OMAP3: cpuidle: change the power domains modes determination logic jean.pihet at newoldbits.com
2011-04-29 11:29 ` Santosh Shilimkar
2011-04-29 14:00 ` Jean Pihet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinEwUukmE2LP6F3q_8KDBHvdRqkVA@mail.gmail.com \
--to=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).