[PATCH 2/9] MTD: pxa3xx_nand: enable multiple chip select support

[adrian.wenl@gmail.com (Lei Wen)]

Hi Artem,

On Wed, Jun 29, 2011 at 3:11 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2011-06-28 at 20:51 -0700, Lei Wen wrote:
>> Current pxa3xx_nand controller has two chip select which
>> both be workable. This patch enable this feature.
>>
>> Update platform driver to support this feature.
>>
>> Another notice should be taken that:
>> When you want to use this feature, you should not enable the
>> keep configuration feature, for two chip select could be
>> attached with different nand chip. The different page size
>> and timing requirement make the keep configuration impossible.
>>
>> Signed-off-by: Lei Wen <leiwen@marvell.com>
>> ---
>> ?arch/arm/plat-pxa/include/plat/pxa3xx_nand.h | ? 19 +-
>> ?drivers/mtd/nand/pxa3xx_nand.c ? ? ? ? ? ? ? | ?493 +++++++++++++++----------
>> ?2 files changed, 313 insertions(+), 199 deletions(-)
>
> If someone can review this patch - good let's see how many Reviewed-by
> tags we get. But I think it is not very reviewable because of the size.
>
> AFAICK, what you do here is
>
> 1. Introduce new structure struct pxa3xx_nand_host
> 2. Move several fields from struct pxa3xx_nand_info to struct
> pxa3xx_nand_host
>
> And only this alone adds a lot of noise to the patch.
>
> And also you have some real functional changes.
>
> So I'd suggest you to split this patch at least on 2 - the first one
> would introduce struct pxa3xx_nand_host, moved some fields, and do all
> the host<->info renamings. You can split this on several steps and move
> only several fields at a time.
>
> Then a separate patch would do some more functional changes. How does
> this sound?
>

I'm ok with this, patches to come.

Thanks,
Lei