linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: per.forlin@linaro.org (Per Forlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sdio: optimized SDIO IRQ handling for single function
Date: Wed, 4 May 2011 18:03:13 +0200	[thread overview]
Message-ID: <BANLkTinUnDN_ZE5hQuQvDUTFUJV+ZpTTag@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1105041117170.24613@xanadu.home>

On 4 May 2011 17:20, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> On Wed, 4 May 2011, Per Forlin wrote:
>
>> On 4 May 2011 05:40, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
>> > On Tue, 3 May 2011, Per Forlin wrote:
>> >
>> >> From: Stefan Nilsson XK <stefan.xk.nilsson@stericsson.com>
>> >>
>> >> If there is only 1 function registered, and IRQ:s are supported and
>> >> currently enabled, call the callback handler directly
>> >> without checking the CCCR registers.
>> >>
>> >> Signed-off-by: Stefan Nilsson XK <stefan.xk.nilsson@stericsson.com>
>> >> Signed-off-by: Per Forlin <per.forlin@linaro.org>
>> >
>> > Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
>> >
>> I am working o a patch version 2 after offline discussion with Ulf Hansson.
>> Instead of adding this code here.
>> Add sdio_single_func member in mmc_card. Set and reset this function
>> in sdio_claim_irq and sdio_release_irq.
>> process_sdio_pending_irqs would only check if sdio_single_func is !=
>> null and call it.
>
> Yes, that's what I was about to propose after thinking about it some
> more.
>
>> This will result in a bigger patch overall but the new code in
>> process_sdio_pending_irqs will be minimal.
>
> Something like this (untested) ?
>
What I had in mind is similar. Please let me know what you think. I am
about to post "patch v2"

Regards,
Per

      reply	other threads:[~2011-05-04 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03 20:04 [PATCH] sdio: optimized SDIO IRQ handling for single function Per Forlin
2011-05-04  3:40 ` Nicolas Pitre
2011-05-04  8:36   ` Per Forlin
2011-05-04 15:20     ` Nicolas Pitre
2011-05-04 16:03       ` Per Forlin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinUnDN_ZE5hQuQvDUTFUJV+ZpTTag@mail.gmail.com \
    --to=per.forlin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).