From: highguy@gmail.com (Stijn Devriendt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] RFC: gpio: driver-local pin configuration
Date: Tue, 28 Jun 2011 13:53:07 +0200 [thread overview]
Message-ID: <BANLkTinWmdWgGD9ui+WVV7DyCzy73S5AkQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikpMdakfTU+RRsXQVnpO4-KGkOGJQ@mail.gmail.com>
On Mon, Jun 27, 2011 at 2:37 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Jun 27, 2011 at 2:02 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>> On Mon, Jun 27, 2011 at 01:44:43PM +0200, Linus Walleij wrote:
>>
>>> Yes. To make the driver platform neutral, it needs to for example
>>> provide a callback in the platform data like (* set_pin_bias) or so,
>>> and then your platform has to implement this biasing.
>>
>>> In this specific case that kind of stuff would likely be preferable
>>> to have in the platform anyway, but I understand what you mean.
>>
>> How about device tree usage? ?I guess there we'd end up doing it by
>> putting the configuration on the GPIO end of things rather than on the
>> GPIO user side?
>
> Sorry I can't quite understand that, please elaborate!
>
I have some code doing this as well (in a very limited fashion):
int of_request_gpio(..., int* remaining_flags)
{
of_get_gpio_flags(of_dev, i, remaining_flags)
if (flags & bias_X) {
gpio_set_bias(gpio, ...)
flags &= ~bias_X
}
// interpret all generic flags here
};
So drivers need not worry about all gpio flags and special things.
They just request the pin; what they receive is a fully configured
pin (with the exception of unknown flags passed out via
remaining_flags).
Regards,
Stijn
next prev parent reply other threads:[~2011-06-28 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 8:48 [PATCH 0/2] RFC: gpio: driver-local pin configuration Linus Walleij
2011-06-23 10:54 ` Linus Walleij
2011-06-27 10:57 ` Stijn Devriendt
2011-06-27 11:44 ` Linus Walleij
2011-06-27 12:02 ` Mark Brown
2011-06-27 12:37 ` Linus Walleij
2011-06-28 11:53 ` Stijn Devriendt [this message]
2011-06-29 6:18 ` Linus Walleij
2011-06-29 7:39 ` Stijn Devriendt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinWmdWgGD9ui+WVV7DyCzy73S5AkQ@mail.gmail.com \
--to=highguy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).