From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] gpio/mxc: Change gpio-mxc into an upstanding gpio driver
Date: Mon, 6 Jun 2011 02:18:29 -0600 [thread overview]
Message-ID: <BANLkTinY44trVnt-XXaH85Vsj46put6N1Q@mail.gmail.com> (raw)
In-Reply-To: <20110606081205.GC32632@pengutronix.de>
On Mon, Jun 6, 2011 at 2:12 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Mon, Jun 06, 2011 at 01:52:41AM -0600, Grant Likely wrote:
>> On Mon, Jun 06, 2011 at 12:07:55AM +0800, Shawn Guo wrote:
>> > The patch makes necessary changes on gpio-mxc as below to turn it
>> > into an upstanding gpio driver.
>> >
>> > ?* Add a list to save all mx2 ports references, so that
>> > ? ?mx2_gpio_irq_handler can walk through all interrupt status
>> > ? ?registers
>> >
>> > ?* Use readl/writel to replace mach-specific accessors
>> > ? ?__raw_readl/__raw_writel
>> >
>> > ?* Change mxc_gpio_init into mxc_gpio_probe function
>> >
>> > ?* Move "struct mxc_gpio_port" into gpio-mxc.c, as it needs not to
>> > ? ?be public at all, and also make some other cleanup on
>> > ? ?plat-mxc/include/mach/gpio.h at the same time
>> >
>> > And the patch then migrates mach-imx and mach-mx5 to the updated
>> > driver by adding corresponding platform devices.
>> >
>> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>> > Acked-by: Olof Johansson <olof@lixom.net>
>>
>> Applied, thanks.
>
> I'm not completely happy with this patch going through your tree. It
> does massive changes to arch/arm/mach-*mx*, so expect merge conflicts
> here.
There are also massive changes going on in drivers/gpio. The solution
here is to probably put these changes into a new dedicated branch
based on Linus' tree, we both agree not to rebase that branch, and
both of us merge the branch into our trees.
g.
next prev parent reply other threads:[~2011-06-06 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 16:07 [PATCH v4 0/2] Move plat-mxc gpio driver into drivers/gpio Shawn Guo
2011-06-05 16:07 ` [PATCH v4 1/2] gpio/mxc: Move Freescale MXC gpio driver to drivers/gpio Shawn Guo
2011-06-06 7:51 ` Grant Likely
2011-06-05 16:07 ` [PATCH v4 2/2] gpio/mxc: Change gpio-mxc into an upstanding gpio driver Shawn Guo
2011-06-06 7:52 ` Grant Likely
2011-06-06 8:12 ` Sascha Hauer
2011-06-06 8:18 ` Grant Likely [this message]
2011-06-06 8:47 ` Sascha Hauer
2011-06-06 16:03 ` Grant Likely
2011-06-06 8:50 ` [PATCH v4 0/2] Move plat-mxc gpio driver into drivers/gpio Sascha Hauer
2011-06-06 12:22 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinY44trVnt-XXaH85Vsj46put6N1Q@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).