From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver
Date: Sat, 9 Apr 2011 01:46:29 +0200 [thread overview]
Message-ID: <BANLkTin_-hhcexTd67HviTqM4bjXMZxweA@mail.gmail.com> (raw)
In-Reply-To: <20110408220157.GC26019@kroah.com>
2011/4/9 Greg KH <greg@kroah.com>:
>> +static void axi_release_core_dev(struct device *dev)
>> +{
>> + ? ? kfree(dev);
>> +}
>
> This is wrong, unless you are really only creating a 'struct device'.
> Why are you doing that instead of embedding struct device in your
> structure?
Hm, I think Greg found explanation why we can not reload axi driver
successfully :)
I'll take care of your comment after weekend, thank you everybody.
--
Rafa?
next prev parent reply other threads:[~2011-04-08 23:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 19:45 [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver Rafał Miłecki
2011-04-08 19:28 ` Joe Perches
2011-04-08 19:46 ` Rafał Miłecki
2011-04-08 19:55 ` Joe Perches
2011-04-09 0:03 ` Rafał Miłecki
2011-04-09 0:07 ` Joe Perches
2011-04-08 20:00 ` Gábor Stefanik
2011-04-08 22:01 ` Greg KH
2011-04-08 23:46 ` Rafał Miłecki [this message]
2011-04-10 15:52 ` Rafał Miłecki
2011-04-10 16:20 ` Greg KH
2011-04-11 16:59 ` Arend van Spriel
2011-04-11 17:24 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin_-hhcexTd67HviTqM4bjXMZxweA@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).