From: per.forlin@linaro.org (Per Forlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 02/12] mmc: mmc_test: add debugfs file to list all tests
Date: Sun, 8 May 2011 15:12:46 +0200 [thread overview]
Message-ID: <BANLkTindMsH4ozajW3E3ifBnrsS=gpOaOQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTim2k_hb0Bw_cYeTUv-dMzyWVPO+gA@mail.gmail.com>
On 8 May 2011 00:18, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sat, May 7, 2011 at 10:14 PM, Per Forlin <per.forlin@linaro.org> wrote:
>> Add a debugfs file "testlist" to print all available tests
>>
>> Signed-off-by: Per Forlin <per.forlin@linaro.org>
>> ---
>> ?drivers/mmc/card/mmc_test.c | ? 30 ++++++++++++++++++++++++++++++
>> ?1 files changed, 30 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
>> index abc1a63..c1c3c5a 100644
>> --- a/drivers/mmc/card/mmc_test.c
>> +++ b/drivers/mmc/card/mmc_test.c
>
>
>> @@ -2476,6 +2502,10 @@ static int mmc_test_register_file_test(struct mmc_card *card)
>> ? ? ? ? ? ? ? ?file = debugfs_create_file("test", S_IWUSR | S_IRUGO,
>> ? ? ? ? ? ? ? ? ? ? ? ?card->debugfs_root, card, &mmc_test_fops_test);
>>
>> + ? ? ? if (card->debugfs_root)
>> + ? ? ? ? ? ? ? file = debugfs_create_file("testlist", S_IRUGO,
>> + ? ? ? ? ? ? ? ? ? ? ? card->debugfs_root, card, &mmc_test_fops_testlist);
>> +
>> ? ? ? ?if (IS_ERR_OR_NULL(file)) {
>> ? ? ? ? ? ? ? ?dev_err(&card->dev,
>> ? ? ? ? ? ? ? ? ? ? ? ?"Can't create file. Perhaps debugfs is disabled.\n");
> I think you also need to use similar error path for both files: test
> and testlist.
Thanks, I'll fix that and add this check for both.
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
Regards,
Per
next prev parent reply other threads:[~2011-05-08 13:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 19:14 [PATCH v3 00/12] mmc: use nonblock mmc requests to minimize latency Per Forlin
2011-05-07 19:14 ` [PATCH v3 01/12] mmc: add none blocking mmc request function Per Forlin
2011-05-07 19:14 ` [PATCH v3 02/12] mmc: mmc_test: add debugfs file to list all tests Per Forlin
2011-05-07 22:18 ` Andy Shevchenko
2011-05-08 13:12 ` Per Forlin [this message]
2011-05-07 19:14 ` [PATCH v3 03/12] mmc: mmc_test: add test for none blocking transfers Per Forlin
2011-05-07 19:14 ` [PATCH v3 04/12] mmc: add member in mmc queue struct to hold request data Per Forlin
2011-05-07 19:14 ` [PATCH v3 05/12] mmc: add a block request prepare function Per Forlin
2011-05-07 19:15 ` [PATCH v3 06/12] mmc: move error code in mmc_block_issue_rw_rq to a separate function Per Forlin
2011-05-07 19:15 ` [PATCH v3 07/12] mmc: add a second mmc queue request member Per Forlin
2011-05-07 19:15 ` [PATCH v3 08/12] mmc: add handling for two parallel block requests in issue_rw_rq Per Forlin
2011-05-07 19:15 ` [PATCH v3 09/12] mmc: test: add random fault injection in core.c Per Forlin
2011-05-07 19:15 ` [PATCH v3 10/12] omap_hsmmc: use original sg_len for dma_unmap_sg Per Forlin
2011-05-07 19:15 ` [PATCH v3 11/12] omap_hsmmc: add support for pre_req and post_req Per Forlin
2011-05-07 19:15 ` [PATCH v3 12/12] mmci: implement pre_req() and post_req() Per Forlin
2011-05-09 2:05 ` [PATCH v3 00/12] mmc: use nonblock mmc requests to minimize latency Philip Rakity
2011-05-09 12:34 ` Per Forlin
2011-05-09 13:44 ` Philip Rakity
2011-05-12 4:28 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTindMsH4ozajW3E3ifBnrsS=gpOaOQ@mail.gmail.com' \
--to=per.forlin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).