From: christian.riesch@omicron.at (Christian Riesch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] davinci: da850: move input frequency to board specific files
Date: Thu, 9 Jun 2011 12:05:12 +0200 [thread overview]
Message-ID: <BANLkTinjV3cdNe92MkiWcXH8GJmOcF_nuA@mail.gmail.com> (raw)
In-Reply-To: <874o42wpec.fsf@ti.com>
Hi Kevin,
On Tue, Jun 7, 2011 at 12:44 AM, Kevin Hilman <khilman@ti.com> wrote:
> Christian Riesch <christian.riesch@omicron.at> writes:
>
>> From: Bob Dunlop <bob.dunlop@xyzzy.org.uk>
>>
>> Currently the input frequency of the SoC is hardcoded in the SoC specific
>> da850.c file to 24 MHz. Since the SoC accepts input frequencies in a wide
>> range from 12 to 50 MHz, boards with different oscillator/crystal
>> frequencies may be built.
>>
>> This patch allows setting a different input frequency in the board
>> specific files to support boards with oscillator/crystal frequencies other
>> than 24 MHz.
>>
>> Signed-off-by: Bob Dunlop <bob.dunlop@xyzzy.org.uk>
>> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
>
> Why not allow board code to just do a clk_set_rate()?
I'm fine with this method (In fact it was the first thing that I
tried, I added a .set_rate method to ref_clk, it worked well for me).
However I wonder whether first initializing the clock with the wrong
value (24 MHz) and later correcting it via clk_set_rate() would break
something. In the meantime, the data in the clock tree do not reflect
the actual frequencies that are present on the SoC.
Christian
next prev parent reply other threads:[~2011-06-09 10:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 8:37 [PATCH] davinci: da850: move input frequency to board specific files Christian Riesch
2011-05-27 9:20 ` [PATCH V2] " Christian Riesch
2011-05-28 9:55 ` Menon, Nishanth
2011-05-30 8:23 ` Christian Riesch
2011-06-01 17:15 ` Nori, Sekhar
2011-06-06 22:44 ` Kevin Hilman
2011-06-07 10:39 ` Nori, Sekhar
2011-06-07 16:23 ` Kevin Hilman
2011-06-08 12:08 ` Nori, Sekhar
2011-06-14 15:33 ` Nori, Sekhar
2011-06-14 17:39 ` [PATCH] davinci: da850: add a .set_rate method to ref_clk Christian Riesch
2011-06-28 11:23 ` Nori, Sekhar
2011-06-28 15:10 ` [PATCH v2] " Christian Riesch
2011-07-06 16:36 ` Nori, Sekhar
2011-06-16 15:06 ` [PATCH V2] davinci: da850: move input frequency to board specific files Kevin Hilman
2011-06-09 10:05 ` Christian Riesch [this message]
2011-06-09 16:48 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinjV3cdNe92MkiWcXH8GJmOcF_nuA@mail.gmail.com \
--to=christian.riesch@omicron.at \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).