From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Trivial: ARM: pxa168: Bug fix - correct UART DMA channels
Date: Wed, 27 Apr 2011 15:28:19 +0800 [thread overview]
Message-ID: <BANLkTinmvgHHJXOphd0X8huPMArhkogfMw@mail.gmail.com> (raw)
In-Reply-To: <4DB79E76.1080402@einfochips.com>
On Wed, Apr 27, 2011 at 12:41 PM, Tanmay Upadhyay
<tanmay.upadhyay@einfochips.com> wrote:
> On Tuesday 04 January 2011 11:37 AM, Tanmay Upadhyay wrote:
>
> According to ARMADA_16x_Software_Manual.pdf, DMA channels for
> UART1 are 19, 20 and DMA channels for UART2 are 21, 22.
>
> It's of little significance for now as the PXA UART driver
> doesn't use DMA as of now.
>
> Signed-off-by: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
> ---
> arch/arm/mach-mmp/pxa168.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c
> index 72b4e76..7564739 100644
> --- a/arch/arm/mach-mmp/pxa168.c
> +++ b/arch/arm/mach-mmp/pxa168.c
> @@ -147,8 +147,8 @@ void pxa168_clear_keypad_wakeup(void)
> }
>
> /* on-chip devices */
> -PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 21, 22);
> -PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 23, 24);
> +PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 19, 20);
> +PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 21, 22);
> PXA168_DEVICE(twsi0, "pxa2xx-i2c", 0, TWSI0, 0xd4011000, 0x28);
> PXA168_DEVICE(twsi1, "pxa2xx-i2c", 1, TWSI1, 0xd4025000, 0x28);
> PXA168_DEVICE(pwm1, "pxa168-pwm", 0, NONE, 0xd401a000, 0x10);
>
> Is there anything wrong with the patch? Any suggestions please?
>
Hi Tanmay,
Nothing wrong with the patch. Sorry it was kept in the bottom of my
mail box for such a long time.
Jason & Haojian,
I need your double-check and Ack. Thanks.
> Thanks,
>
> Tanmay
>
prev parent reply other threads:[~2011-04-27 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 6:07 [PATCH] Trivial: ARM: pxa168: Bug fix - correct UART DMA channels Tanmay Upadhyay
2011-04-27 4:41 ` Tanmay Upadhyay
2011-04-27 7:28 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinmvgHHJXOphd0X8huPMArhkogfMw@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).