From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mioa701: move gpio-pullup functionality to gpio-vbus
Date: Wed, 22 Jun 2011 16:40:52 +0400 [thread overview]
Message-ID: <BANLkTintf_rraxYLEB__4JWOfHw1-qm8pQ@mail.gmail.com> (raw)
In-Reply-To: <1308745217-10883-2-git-send-email-dbaryshkov@gmail.com>
Oops... See bellow,
On 6/22/11, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
> gpio-vbus can (and should?) handle D+ pullup gpio for us. Move gpio-pullup
> handling
> to gpio-vbus and stop providing udc_info as it's empty now.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> arch/arm/mach-pxa/mioa701.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
> index bcbd359..e712c9d 100644
> --- a/arch/arm/mach-pxa/mioa701.c
> +++ b/arch/arm/mach-pxa/mioa701.c
> @@ -402,14 +402,10 @@ static void gsm_exit(void)
> /*
> * USB UDC
> */
> -static struct pxa2xx_udc_mach_info mioa701_udc_info = {
> - .gpio_pullup = GPIO22_USB_ENABLE,
> -};
> -
> struct gpio_vbus_mach_info gpio_vbus_data = {
> .gpio_vbus = GPIO13_nUSB_DETECT,
> .gpio_vbus_inverted = 1,
> - .gpio_pullup = -1,
> + .gpio_pullup = GPIO22_USB_ENABLE,
This should be also
+ .disconnect_on_suspend = 1,
> };
>
> /*
> @@ -770,7 +766,6 @@ static void __init mioa701_machine_init(void)
> pxa_set_fb_info(NULL, &mioa701_pxafb_info);
> pxa_set_mci_info(&mioa701_mci_info);
> pxa_set_keypad_info(&mioa701_keypad_info);
> - pxa_set_udc_info(&mioa701_udc_info);
> pxa_set_ac97_info(&mioa701_ac97_info);
> pm_power_off = mioa701_poweroff;
> arm_pm_restart = mioa701_restart;
> --
> 1.7.5.3
>
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2011-06-22 12:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 12:20 [PATCH 1/2] gpio-vbus: support disabling D+ pullup on suspend Dmitry Eremin-Solenikov
2011-06-22 12:20 ` [PATCH 2/2] mioa701: move gpio-pullup functionality to gpio-vbus Dmitry Eremin-Solenikov
2011-06-22 12:40 ` Dmitry Eremin-Solenikov [this message]
2011-06-22 13:23 ` [PATCH 1/2] gpio-vbus: support disabling D+ pullup on suspend Felipe Balbi
2011-06-22 13:52 ` Dmitry Eremin-Solenikov
2011-06-22 14:01 ` Felipe Balbi
2011-06-22 14:15 ` Dmitry Eremin-Solenikov
2011-06-22 14:20 ` Felipe Balbi
2011-06-22 14:26 ` Dmitry Eremin-Solenikov
2011-06-22 14:30 ` Felipe Balbi
2011-06-22 14:30 ` Alan Stern
2011-06-22 14:32 ` Felipe Balbi
2011-06-22 15:02 ` Alan Stern
2011-06-22 15:19 ` Felipe Balbi
2011-06-25 9:26 ` Robert Jarzmik
2011-06-25 10:33 ` Dmitry Eremin-Solenikov
2011-06-25 12:02 ` Alan Stern
2011-06-27 20:39 ` Robert Jarzmik
2011-06-28 2:41 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTintf_rraxYLEB__4JWOfHw1-qm8pQ@mail.gmail.com \
--to=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).