linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][WAS:bcmai, axi] bcma: add Broadcom specific AMBA bus driver
Date: Sun, 8 May 2011 17:25:55 +0200	[thread overview]
Message-ID: <BANLkTinujj_E4xPvbXB_AQM-d9BqHRts8Q@mail.gmail.com> (raw)
In-Reply-To: <201105081706.12449.arnd@arndb.de>

2011/5/8 Arnd Bergmann <arnd@arndb.de>:
> On Saturday 07 May 2011, Rafa? Mi?ecki wrote:
>> > Well, maybe. We call it only once, at init time. In any case we're
>> > still waiting for Broadcom to clarify which cores are really used for
>> > BCMA.
>>
>> Arnd: did you have a look at defines at all?
>>
>> Most of the defines have values in range 0x800 ? 0x837. Converting
>> this to array means loosing 0x800 u16 entries. We can not use 0x800
>> offset, because there are also some defined between 0x000 and 0x800:
>> #define BCMA_CORE_OOB_ROUTER ? ? ? ? ? 0x367 ? /* Out of band */
>> #define BCMA_CORE_INVALID ? ? ? ? ? ? ?0x700
>
> I did not mean using the enum value as index, just make an array of
> simple structs:
>
> struct bcma_device_name {
> ? ? ? ?unsigned int id;
> ? ? ? ?const char *name;
> };
>
> struct bcma_device_name bcma_device_names = {
> ? ? ? ?{ BCMA_CORE_OOB_ROUTER, "Out of band router" },
> ? ? ? ?{ BCMA_CORE_INVALID, ? ?"Invalid" },
> ? ? ? ?...
> };

Arnd, right now I'm loosing a lot of time (I could spent on improving
bcma or b43) on posting new version of this huge patch with single
changes. Changes that can easily be introduced later without breaking
driver, ABI, etc.

I'll be glad to try your solution later, when we get this patch
merged. I'll be much easier to play with such a differences then.
Thanks for sharing this idea.

Right now I want to focus on some bugs in driver that don't allow it
being merged.

-- 
Rafa?

  reply	other threads:[~2011-05-08 15:25 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 21:59 [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver Rafał Miłecki
2011-05-05 22:59 ` [PATCH][WAS:bcmai, axi] " Julian Calaby
2011-05-05 23:01   ` Rafał Miłecki
2011-05-06 14:05 ` Arnd Bergmann
2011-05-06 14:50   ` Rafał Miłecki
2011-05-07 13:34     ` Rafał Miłecki
2011-05-07 13:55       ` [PATCH][WAS:bcmai,axi] " Michael Büsch
2011-05-07 16:29         ` Arend van Spriel
2011-05-07 16:49           ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 17:04             ` [PATCH][WAS:bcmai,axi] " Arend van Spriel
2011-05-07 17:20               ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 17:51       ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 18:05         ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 18:26           ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 18:48             ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 19:02               ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 19:21                 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-07 19:35                   ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-08  1:44                     ` Michael Büsch
2011-05-08  2:01                       ` George Kashperko
2011-05-07 19:03               ` George Kashperko
2011-05-08  8:43               ` Arend van Spriel
2011-05-08 10:16               ` Russell King - ARM Linux
2011-05-08 10:37                 ` [PATCH][WAS:bcmai, axi] " Rafał Miłecki
2011-05-08 10:50                   ` [PATCH][WAS:bcmai,axi] " Russell King - ARM Linux
2011-05-08 15:06       ` [PATCH][WAS:bcmai, axi] " Arnd Bergmann
2011-05-08 15:25         ` Rafał Miłecki [this message]
2011-05-08 15:54           ` Arnd Bergmann
2011-05-08 14:47     ` Arnd Bergmann
2011-05-08 14:59       ` Rafał Miłecki
2011-05-08 15:59         ` Arnd Bergmann
2011-05-09 14:33           ` Rafał Miłecki
2011-05-09 15:37             ` Greg KH
2011-05-09 15:48               ` Rafał Miłecki
2011-05-07 16:13 ` Hauke Mehrtens
2011-05-07 16:23   ` Rafał Miłecki
2011-05-07 16:32     ` Hauke Mehrtens
2011-05-07 16:51       ` Rafał Miłecki
2011-05-07 17:24         ` Hauke Mehrtens
2011-05-07 17:35           ` Rafał Miłecki
2011-05-07 17:45           ` [PATCH][WAS:bcmai,axi] " George Kashperko
2011-05-07 22:42           ` Henry Ptasinski
2011-05-07 23:17             ` [PATCH][WAS:bcmai, axi] " Hauke Mehrtens
2011-05-08 12:48 ` Hauke Mehrtens
2011-05-08 12:55   ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinujj_E4xPvbXB_AQM-d9BqHRts8Q@mail.gmail.com \
    --to=zajec5@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).