From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6407EC33C9E for ; Tue, 28 Jan 2020 10:34:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3527121739 for ; Tue, 28 Jan 2020 10:34:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EIikCEou" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3527121739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:To:From: Subject:Date:In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=cUonX275bPqXBy6qhvcfVY01oFdOK0nWXteHZIQlDYg=; b=EIikCEours2N1U TOEkxKFMotaTHGfKmj7Veeb8mTHk/ok93rEGjNG2dsVkV98Mwav1VQs3Ps49u6bazgclLJvNGh5Kv diDuGP+DI1Rt91HrW/OLRITnFlRPi4zqgTL44zt/5pnCVEX2xk/cE6IslWP9b/+hk9Y9TsXZHR9BT vxuo0joB1nLXLO5stVgAVBQkM49kCgb0vuMCnJKRA3JGKRUU42/ym3bRJ3A7+8lnpIkeDBI257psI HXf4AixEcd9wP7k/cuPxP5UQ2vmhHxznZAZx9WC6TScpWZC+lCjqIFvcvNct0bh4jwg8iOlksEcpf /Td6Yeona7/1qkUZexYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwOCp-0002rZ-Ry; Tue, 28 Jan 2020 10:34:51 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwOCj-0002qw-5s for linux-arm-kernel@lists.infradead.org; Tue, 28 Jan 2020 10:34:49 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 51BA8ACA3; Tue, 28 Jan 2020 10:34:43 +0000 (UTC) In-Reply-To: <1580148908-4863-1-git-send-email-stefan.wahren@i2se.com> Date: Tue, 28 Jan 2020 11:17:17 +0100 Subject: Re: [RFC PATCH 0/4] pinctrl: bcm2835: Add support for all BCM2711 GPIOs From: "Nicolas Saenz Julienne" To: "Stefan Wahren" , "Florian Fainelli" , "Linus Walleij" , "Ray Jui" , "Scott Branden" Message-Id: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200128_023445_375413_2A634CE1 X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , linux-gpio@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon Jan 27, 2020 at 7:15 PM, Stefan Wahren wrote: > The BCM2711 supports 58 GPIOs [1] by using the existing BCM2835 GPIO > registers > completely. So there is no need to change the binding. > > Patch 1 and 2 prepare the pinctrl driver to be extended to 58 GPIOs in > Patch 3. > I didn't want to squash them in order to make review as easy as > possible. > The final patch 4 assigns all SoC GPIOs a label as we already did for > the older Raspberry Pi boards. > > [1] - > https://github.com/raspberrypi/linux/issues/3101#issuecomment-573092294 > > Stefan Wahren (4): > pinctrl: bcm2835: Drop unused define > pinctrl: bcm2835: Refactor platform data > pinctrl: bcm2835: Add support for all GPIOs on BCM2711 > ARM: dts: bcm2711-rpi-4-b: Add SoC GPIO labels > > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 74 ++++++++++++++++++++++++ > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 106 > ++++++++++++++++++++++++++-------- > 2 files changed, 156 insertions(+), 24 deletions(-) Apart from the review, I gave it a test on an RPi4 and RPi3b, looks good to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel