From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F6BC2BA83 for ; Fri, 14 Feb 2020 10:55:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 140D1222C4 for ; Fri, 14 Feb 2020 10:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jqeZz6IS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 140D1222C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Subject: To:From:Date:In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=HmfEz2XRiKEiVNVyZw462XxV/+ZA+XZG8kS4M5jDCSI=; b=jqeZz6ISU2aBaQ mHDxfoDKsu1iHeba5hAloHGjQG/zPxl+4Ti6MCqtnl81beo2T9JUmgjKV27yLeLsPJBXyHqauvkmT EsKYpyHlnKitE//pcvCAkwqmojql6qImS2qilEIDlx5FZ1mmJZsvsIjlzm+S2vo0OWq45l2I1nRoe fhIMzAVYo5AoEl7S601uGHutbLxfcZzACbwuNOg4AsTXEZc1eObf3QjQ6O1+/D0ZjyA5ql7qEveqc 82EkJGIuXFFKMpQZXizSU7UbOFYpF1A2QnuFAotMmtjii+YZbmLGzKB7VAnB/YeNDSUBkF0nGquA2 KxKvEwTlLdM6WbWS2SMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2YdO-0007Nr-03; Fri, 14 Feb 2020 10:55:46 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2YdL-0007N8-EF for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 10:55:45 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 49556ADDA; Fri, 14 Feb 2020 10:55:41 +0000 (UTC) In-Reply-To: <20200213025930.27943-4-jaedon.shin@gmail.com> Date: Fri, 14 Feb 2020 11:55:23 +0100 From: "Nicolas Saenz Julienne" To: "Jaedon Shin" , "Florian Fainelli" , Subject: Re: [PATCH 3/3] PCI: brcmstb: Drop clk_put when probe fails and remove Message-Id: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_025543_624767_4389AE5A X-CRM114-Status: GOOD ( 14.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , Bartosz Golaszewski , linux-pci@vger.kernel.org, Linus Walleij , Jaedon Shin , linux-gpio@vger.kernel.org, Rob Herring , Gregory Fong , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andrew Murray MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu Feb 13, 2020 at 11:59 AM, Jaedon Shin wrote: > devm_clk_get* APIs are device managed and get freed automatically when > the device detaches. so there is no reason to explicitly call clk_put() > in probe or remove functions. > > Signed-off-by: Jaedon Shin > --- Acked-by: Nicolas Saenz Julienne Thanks! > drivers/pci/controller/pcie-brcmstb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c > b/drivers/pci/controller/pcie-brcmstb.c > index 0e0ca39a680b..3e48d9e238bb 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -972,7 +972,6 @@ static void __brcm_pcie_remove(struct brcm_pcie > *pcie) > brcm_pcie_turn_off(pcie); > brcm_pcie_regulator_disable(pcie); > clk_disable_unprepare(pcie->clk); > - clk_put(pcie->clk); > } > > static int brcm_pcie_remove(struct platform_device *pdev) > -- > 2.21.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel