From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38A6C2BA83 for ; Fri, 14 Feb 2020 11:07:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC6922082F for ; Fri, 14 Feb 2020 11:07:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JTKFDny8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC6922082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:To:From: Subject:Date:In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=1tBrCSFNTUZuqzHBM9Mzzbr3scGJvzgKTlXcgxEjRNw=; b=JTKFDny8yuVEs3 FuUVkSURJDkKaIZM2GkPhOJsMhNvdc3lOeXXJN9RrCIfwNxF4esaSTMNDptglq4Bxi5UN6Uch96we tV5vYzkk31LXgleld/XkDuunqhr1uyLTHk7QTDAYx60pqqgmT6OYWdPSYLzOz0GHsTl8F/MRpXgoJ ki/MFrmdfV59WqMlUqVZqf/qlI0Fu5LE31soCGlLzk2TfU6nfi6c2iQXPt3l70yVpJE8fPKd1s9K2 wbvf4haVLLs0RdUdni+Z4C7WGxjDO+N+XY64Bqyi7WUH/wagMD3QIyypiPQIRpDWQDtGNHCiYgTIj 2aIx8LMslJlETCA2LXAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2YoK-00035K-6d; Fri, 14 Feb 2020 11:07:04 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2YoH-00034t-Qv for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 11:07:03 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 59713B383; Fri, 14 Feb 2020 11:07:00 +0000 (UTC) In-Reply-To: <20200213025930.27943-3-jaedon.shin@gmail.com> Date: Fri, 14 Feb 2020 12:01:58 +0100 Subject: Re: [PATCH 2/3] PCI: brcmstb: Add regulator support From: "Nicolas Saenz Julienne" To: "Jaedon Shin" , "Florian Fainelli" , Message-Id: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_030702_014981_8E4AA870 X-CRM114-Status: UNSURE ( 8.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , Jaedon Shin , Bartosz Golaszewski , Rob Herring , Gregory Fong , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andrew Murray MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu Feb 13, 2020 at 11:59 AM, Jaedon Shin wrote: > @@ -173,8 +174,79 @@ struct brcm_pcie { > int gen; > u64 msi_target_addr; > struct brcm_msi *msi; > +#ifdef CONFIG_REGULATOR Correct me if I'm wrong, but I don't think these #ifdefs are necessary (same below). The regulator code defines empty functions and relevant structures even when not enabled. Regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel