From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8EFEC433F5 for ; Tue, 15 Mar 2022 13:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=22c8Ec/+wgB3X9FkW/sbMdcP2r5L2bf7RC6PNQ5dMbw=; b=YQi7kI1PtAf1mP q/0FmnaNyVtFLaHYGLrzlbHf9/qSUNRpIomGmTqr3jN/jO23ThyZAtfcLiuj86uujtgn/X9X2LO7e AQrxrX/00qM2NUwArKZsj9dvmqBIKixBrPM9sTv2dTa80Bs1sSmSilGuH7xyPohG4VWaMCibqg2wq /QWyb37uwXQn3n+q8ODy7nqEqjIXc4nArLRED9YsK/L7bwxHYl0r6pX+uovoabdj/T0a/9txtlfd3 /8lZBRoexP+GQlJAnHDwJ2x2Vp71fVm1eVGkOLjTATuIyuma+AeddftGIdBFDiEVC/zRzq/29FvHw zzh8KaYMmYCAR17dpEww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU6rL-0096Xm-OK; Tue, 15 Mar 2022 13:05:07 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU6rH-0096WK-TJ for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 13:05:06 +0000 Received: by mail-il1-x134.google.com with SMTP id b5so13228890ilj.9 for ; Tue, 15 Mar 2022 06:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kJctDznwgrmoIyAuf9bUVGsb0D7V175hvwVVt9jW9gw=; b=d4mR+kDbmTiAUcXc1886xV8kIQFzaMsTtL61b7IYflmu+Ku0mBap2UE7WQ0c+R9B4y VKGgMRMRMdT0vmCb6a8Y9ou2iFXvTAvcDQwUpRKcIzLXUVUrRSFPr4U+09U6tQVDIsp8 mW9kRcmtHwZm2chttAOYegWNOglE96/u74Y4lbOxLutYe5vByCWEsnBmNrd98g6yg5mf 8Imx8Ep1Vgw7JS7mKCmRyvEwVqlPS8yBTTsA/UFv1gSGu1z+KI3kIrTRZcdscKSPtXt2 mV+i5dNl1E5GmIKvzailpWsZuMjlmPuAotYPWSZcX94lOxZIF2kV/LWjOxtqZsjYjKw3 fHSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kJctDznwgrmoIyAuf9bUVGsb0D7V175hvwVVt9jW9gw=; b=R4nLhmPjHyv4JpELseaSKnWUICIap4CbKSpTuoXbkEKGE9f5rqwd+9qXudT6zyBg8h RENiPsLGy845SXRqwm7b2kjBExQHoYbBildI99GquVypMMFlbcmJACZP7pjiuDe1NgHE +hnGLxF/xL4q4megv25wuEAcZF4u2A0wdS5ubwympwIUWxguLftKRi3Jop+OwqV0I45H T74RuCCRIyFKSE+6Qyi8OUytk4fGABJn08n/ruxW9t2wlkQUmM3B7JJtB39BxhJSHnY3 w5wcxXeSAcg3BoHNpXdaoXovLhEEXCP9ZkfxV8Fnaf2KVc6k0qdKDxLa7OKw7Sik1q9X 7Obg== X-Gm-Message-State: AOAM5303FdjU3SkAcjUfhDOV/P8vfKTTuN0gKCKZZciLcNDnao7NTjAp yLc+6VPZL6kb/zta+jPjRQXuNADlMt48eFqjEjwzBw== X-Google-Smtp-Source: ABdhPJyrkaCXQOljy5xtaGdh0dwlkFZe7LnuxQg+YrF/pDCR18e8YPQy0VIlL1m27PyYcQCgEKEv1B8FmVzqvSf7344= X-Received: by 2002:a92:ca45:0:b0:2c7:c473:6785 with SMTP id q5-20020a92ca45000000b002c7c4736785mr363815ilo.40.1647349501920; Tue, 15 Mar 2022 06:05:01 -0700 (PDT) MIME-Version: 1.0 References: <20220211160645.GA448@lpieralisi> In-Reply-To: <20220211160645.GA448@lpieralisi> From: Robert Marko Date: Tue, 15 Mar 2022 14:04:51 +0100 Message-ID: Subject: Re: [PATCH v6 0/3] PCI: IPQ6018 platform support To: Lorenzo Pieralisi Cc: Baruch Siach , Andy Gross , Bjorn Andersson , Selvam Sathappan Periakaruppan , Kathiravan T , Bjorn Helgaas , Rob Herring , Thierry Reding , Jonathan Hunter , Jingoo Han , Gustavo Pimentel , "Bryan O'Donoghue" , linux-pci@vger.kernel.org, linux-arm-msm , Linux ARM , linux-tegra@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_060504_031352_B1DF0121 X-CRM114-Status: GOOD ( 29.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 11, 2022 at 5:06 PM Lorenzo Pieralisi wrote: > > On Mon, Feb 07, 2022 at 04:51:23PM +0200, Baruch Siach wrote: > > This series adds support for the single PCIe lane on IPQ6018 SoCs. The code is > > ported from downstream Codeaurora v5.4 kernel. The main difference from > > downstream code is the split of PCIe registers configuration from .init to > > .post_init, since it requires phy_power_on(). > > > > Tested on IPQ6010 based hardware. > > > > Changes in v6: > > > > * Drop DT patch applied to the qcom tree > > > > * Normalize driver changes subject line > > > > * Add a preparatory patch to rename PCIE_CAP_LINK1_VAL to PCIE_CAP_SLOT_VAL, > > and define it using PCI_EXP_SLTCAP_* macros > > > > * Drop a vague comment about ASPM configuration > > > > * Add a comment about the source of delay periods > > > > Changes in v5: > > > > * Remove comments from qcom_pcie_init_2_9_0() (Bjorn Andersson) > > > > Changes in v4: > > > > * Drop applied DT bits > > > > * Add max-link-speed that was missing from the applied v2 patch > > > > * Rebase the driver on v5.16-rc3 > > > > Changes in v3: > > > > * Drop applied patches > > > > * Rely on generic code for speed setup > > > > * Drop unused macros > > > > * Formatting fixes > > > > Changes in v2: > > > > * Add patch moving GEN3_RELATED macros to a common header > > > > * Drop ATU configuration from pcie-qcom > > > > * Remove local definition of common registers > > > > * Use bulk clk and reset APIs > > > > * Remove msi-parent from device-tree > > > > Baruch Siach (2): > > PCI: dwc: tegra: move GEN3_RELATED DBI register to common header > > PCI: qcom: Define slot capabilities using PCI_EXP_SLTCAP_* > > > > Selvam Sathappan Periakaruppan (1): > > PCI: qcom: Add IPQ60xx support > > > > drivers/pci/controller/dwc/pcie-designware.h | 7 + > > drivers/pci/controller/dwc/pcie-qcom.c | 155 ++++++++++++++++++- > > drivers/pci/controller/dwc/pcie-tegra194.c | 6 - > > 3 files changed, 160 insertions(+), 8 deletions(-) > > Bjorn, Andy, > > Can you ACK please if this series is ready to be merged ? Hi, This would also help the IPQ8074 which has the same controller for the Gen3 port. I have been using this for OpenWrt for a while and it works. Regards, Robert > > Thanks, > Lorenzo -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel