From: sandeepa.prabhu@linaro.org (Sandeepa Prabhu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: debug: remove noisy, pointless warning
Date: Mon, 21 Apr 2014 08:33:27 +0530 [thread overview]
Message-ID: <CA+b37P1UtLM_Ah3bw6LPz=ShGYvOhfyM6TpgtH+4zidNS6JeDQ@mail.gmail.com> (raw)
In-Reply-To: <1397734634-14464-1-git-send-email-will.deacon@arm.com>
I am okay with this change, ACK.
Thanks,
~Sandeepa
On 17 April 2014 17:07, Will Deacon <will.deacon@arm.com> wrote:
> Sending a SIGTRAP to a user task after execution of a BRK instruction at
> EL0 is fundamental to the way in which software breakpoints work and
> doesn't deserve a warning to be logged in dmesg. Whilst the warning can
> be justified from EL1, do_debug_exception will already do the right thing,
> so simply remove the code altogether.
>
> Cc: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>
> Reported-by: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
> arch/arm64/kernel/debug-monitors.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
> index ed3955a95747..a7fb874b595e 100644
> --- a/arch/arm64/kernel/debug-monitors.c
> +++ b/arch/arm64/kernel/debug-monitors.c
> @@ -318,9 +318,6 @@ static int brk_handler(unsigned long addr, unsigned int esr,
> if (call_break_hook(regs, esr) == DBG_HOOK_HANDLED)
> return 0;
>
> - pr_warn("unexpected brk exception at %lx, esr=0x%x\n",
> - (long)instruction_pointer(regs), esr);
> -
> if (!user_mode(regs))
> return -EFAULT;
>
> --
> 1.9.1
>
prev parent reply other threads:[~2014-04-21 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 11:37 [PATCH] arm64: debug: remove noisy, pointless warning Will Deacon
2014-04-21 3:03 ` Sandeepa Prabhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+b37P1UtLM_Ah3bw6LPz=ShGYvOhfyM6TpgtH+4zidNS6JeDQ@mail.gmail.com' \
--to=sandeepa.prabhu@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).