[PATCH] arm64: debug: remove noisy, pointless warning

[PATCH] arm64: debug: remove noisy, pointless warning

[Will Deacon]

Sending a SIGTRAP to a user task after execution of a BRK instruction at
EL0 is fundamental to the way in which software breakpoints work and
doesn't deserve a warning to be logged in dmesg. Whilst the warning can
be justified from EL1, do_debug_exception will already do the right thing,
so simply remove the code altogether.

Cc: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>
Reported-by: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
 arch/arm64/kernel/debug-monitors.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
index ed3955a95747..a7fb874b595e 100644
--- a/arch/arm64/kernel/debug-monitors.c
+++ b/arch/arm64/kernel/debug-monitors.c
@@ -318,9 +318,6 @@ static int brk_handler(unsigned long addr, unsigned int esr,
 	if (call_break_hook(regs, esr) == DBG_HOOK_HANDLED)
 		return 0;
 
-	pr_warn("unexpected brk exception at %lx, esr=0x%x\n",
-			(long)instruction_pointer(regs), esr);
-
 	if (!user_mode(regs))
 		return -EFAULT;
 
-- 
1.9.1

[PATCH] arm64: debug: remove noisy, pointless warning

[Sandeepa Prabhu]

I am okay with this change, ACK.

Thanks,
~Sandeepa

On 17 April 2014 17:07, Will Deacon <will.deacon@arm.com> wrote:
> Sending a SIGTRAP to a user task after execution of a BRK instruction at
> EL0 is fundamental to the way in which software breakpoints work and
> doesn't deserve a warning to be logged in dmesg. Whilst the warning can
> be justified from EL1, do_debug_exception will already do the right thing,
> so simply remove the code altogether.
>
> Cc: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>
> Reported-by: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>  arch/arm64/kernel/debug-monitors.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
> index ed3955a95747..a7fb874b595e 100644
> --- a/arch/arm64/kernel/debug-monitors.c
> +++ b/arch/arm64/kernel/debug-monitors.c
> @@ -318,9 +318,6 @@ static int brk_handler(unsigned long addr, unsigned int esr,
>         if (call_break_hook(regs, esr) == DBG_HOOK_HANDLED)
>                 return 0;
>
> -       pr_warn("unexpected brk exception at %lx, esr=0x%x\n",
> -                       (long)instruction_pointer(regs), esr);
> -
>         if (!user_mode(regs))
>                 return -EFAULT;
>
> --
> 1.9.1
>