From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B79CC4338F for ; Mon, 23 Aug 2021 09:47:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC41461373 for ; Mon, 23 Aug 2021 09:47:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC41461373 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sch9gNP1uxoZ89jZqYEJtz93PhIkTAAtV/YeAMyoXGc=; b=Ao8l11KrnymqvE QBe9BVYNzJWrHOJ7OJ3+OdsRCs9ILXsYzm4CAEZKUQYtIZQAUBqGLhvvvgjag7IFm568Di6QeMZEU C2WDjKcH1Sm5T4wry4A8wMeeOsm5RvpBmbSgEqLeEk42CDZ72TPZGAFMLMmRqm6NbwOvglGeIBn3w Er9RzqPJbnnZS6LBWG+8GWNiw076LzJ0t4L+GIr3PX0TuLPCGmeEdYU3Ao7lPsy2QYqco9x2tSYel 8iNWZOR5+SVJlLPrlhcsEsu7vzFBav3iLnz33D4xmukK+SA5Ab/lnfmY5IJWgfOSg3FG8ozzaef4E 1oL8JmncNoHqMGwVWfvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI6WS-00GBZU-7J; Mon, 23 Aug 2021 09:45:40 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI6WL-00GBWq-Fp for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 09:45:37 +0000 Received: by mail-qk1-x736.google.com with SMTP id 22so18537568qkg.2 for ; Mon, 23 Aug 2021 02:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F7puqGkfeq2gGVbcmofYcE+ip9S4w+Znt/a7BmCuaiA=; b=OSftcU2iVhgfPFOaPErRQTCll/bJZOKkUusefGZa8BYEUnQ75P+vSwxeYWSsJqoinv dfWGRCWPGME0eQxGzjQtLWfNQPy4pUDYRRHpQ50KUXHvWQzM3+fRgldsmeli/KlOusHY 28kyryvy0/lNuO/bhpUqo7iy5IQnUl6uz8uTWhl1RozNAOErgFb2Y+9VR9qf5Oz3oygB bxq2L8q8gOxhwbq4FlgOQZhIY9KSz+7Qxjw8vGNtbx+qXdCZeJ+8Oe5pGJHkqzPysYZN CTQWSLTKpAf45wGqwzoLEPymWk12XbstYh/8yV4HO8IdrqJbgwVr0uud9Nkt4lA1Hy/Z OMLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F7puqGkfeq2gGVbcmofYcE+ip9S4w+Znt/a7BmCuaiA=; b=jaoHfBdQvD9SGbFYprIzqV3NxGCnOJHydRQBckIUx9iAXZ6aoo37430x0q2jVaujLd uHwOqoOA1v8NDjsBZIIe2Lp4E1/EOFHjGs/MJRquhlHQvafbcDUXq9PN6Gs1fhFXj+j0 X7x/IAY2sgAIyF8LunfCgIzgFsWsbtOSI8w408uViczJJkEix0rlcdRihtpe8LPx0H2J EQNP4d3yMssvhTBXfj8jK58AmyK+OitZX265/5tuPsarY9m2lNrZ3ScbQEnmzFntu6iZ i1E10qm+memp1syo22ygZF/nvJs+Ix/PEUwxk7wu6dKmNIAyaxdYi+SSw8lvA0G78a2d 6BlA== X-Gm-Message-State: AOAM532Th2BRV3tqK6pcrR9/nLI0fi7965aLBdMxLioWuBSVVnXMk0kM PIrRlXmEWuq181oPaK3eWa7imNObe04ClpHJ5vE= X-Google-Smtp-Source: ABdhPJyFmowjR5zIGMC0Vgvyna9Kic4jnFTLMo+xE44ALt5B0HuBVM2mxtoSwJRz/bmkw+T0BqVkugQmPeZyRIbYTjA= X-Received: by 2002:a05:620a:14b1:: with SMTP id x17mr19679850qkj.37.1629711931478; Mon, 23 Aug 2021 02:45:31 -0700 (PDT) MIME-Version: 1.0 References: <1629453791-10580-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Mon, 23 Aug 2021 17:45:20 +0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: Add fsl,imx-dsp-rproc binding document To: Rob Herring Cc: Shengjiu Wang , ohad@wizery.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-remoteproc@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_024533_574010_9827A99E X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob On Sat, Aug 21, 2021 at 4:28 AM Rob Herring wrote: > > On Fri, Aug 20, 2021 at 06:03:10PM +0800, Shengjiu Wang wrote: > > Define the compatible string and properties needed by imx_dsp_rproc > > driver. > > > > Signed-off-by: Shengjiu Wang > > --- > > .../remoteproc/fsl,imx-dsp-rproc.yaml | 123 ++++++++++++++++++ > > 1 file changed, 123 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/fsl,imx-dsp-rproc.yaml > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-dsp-rproc.yaml > > new file mode 100644 > > index 000000000000..7eba49aa959e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-dsp-rproc.yaml > > @@ -0,0 +1,123 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/remoteproc/fsl,imx-dsp-rproc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: i.MX DSP Remoteproc Devices > > + > > +maintainers: > > + - Shengjiu Wang > > + > > +description: > > + This binding provides support for DSP processors found on i.mX family of SoCs > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8qxp-hifi4 > > + - fsl,imx8qm-hifi4 > > + - fsl,imx8mp-hifi4 > > + - fsl,imx8ulp-hifi4 > > + > > + clocks: > > + description: | > > + Main functional clock for the remote processor > > Don't need '|' if no formatting. Ok, will update it. > > > + minItems: 1 > > + maxItems: 32 > > + > > + clock-names: > > + description: > > + List of clock names for the remote processor. > > + dsp_clkx for clocks of dsp itself. > > + per_clkx for clocks of peripherals used by dsp. > > Sounds like constraints that should be a schema. But this looks like > some random collection of clocks, not clocks for the DSP h/w. The DSP may use some peripheral devices, then we need to enable the clock in this driver. Using which peripherals depends on the DSP firmware, so we didn't specify the clock name here. I will add below items for this. items: - const: dsp_clk1 - const: dsp_clk2 - const: dsp_clk3 - const: dsp_clk4 - const: dsp_clk5 - const: dsp_clk6 - const: dsp_clk7 - const: dsp_clk8 - const: per_clk1 - const: per_clk2 - const: per_clk3 - const: per_clk4 - const: per_clk5 - const: per_clk6 - const: per_clk7 - const: per_clk8 - const: per_clk9 - const: per_clk10 - const: per_clk11 - const: per_clk12 - const: per_clk13 - const: per_clk14 - const: per_clk15 - const: per_clk16 - const: per_clk17 - const: per_clk18 > > > + minItems: 1 > > + maxItems: 32 > > + > > + syscon: > > Vendor prefix and name it based on what it points to or is used for. Ok, will update it. best regards Wang shengjiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel