From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C6AC0650F for ; Mon, 5 Aug 2019 10:07:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 450872086D for ; Mon, 5 Aug 2019 10:07:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="brPymTo+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PrT5zzBQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 450872086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6IamFyVgfaZK86nwWEOa/tnsQCZjb9tRXuRGitpIbRo=; b=brPymTo+K35buZ DB8PNGREXpZyMBxSTwSTFXN4alETwB7NQDLJ2h8Lo1iB6qDzqFs9iGdfNSUZ8P8RyMa9ZexjGv3UW wsWv3VYUMJ1/sat9ZEWPIEXSgB761E3KTOB+QejOoPMgDnKbferJiO5MvckbvAqwfI42BA7YMJt28 H9ag9sl12+ZU/O49yeoAQStD4Scwdu4hSj/ffJEeHx7Up2uH7yYJHocUHYqMxAPa35jnkhK0FtAzn 62HUWYjN9I2txOPFwtKDbf1Qv9d+YAQ01JUeWQxAZKegO7AWZap3fh1wySUqjaf//A4gJQUitykVO szaskE1HjTZCDufSckKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huZu2-0007vz-TK; Mon, 05 Aug 2019 10:07:42 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huZtz-0007vV-K5 for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 10:07:41 +0000 Received: by mail-ed1-x544.google.com with SMTP id m10so78106164edv.6 for ; Mon, 05 Aug 2019 03:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wjg3An6g6rq9jyoAy9XejRIo5MdOt8OaZv07jbbBozE=; b=PrT5zzBQ2ANbtMmVxjpQ5lb8jB/eUO4fT2D+8f/MhrSwoTta8UNQfpbziADbssapcu Rn5giFrSS8yY9Z6qIcwmAwHtj53dl2928FRT1kCYRHn6nUtjSmynaR7FnEMjxo4fqSDq UdrZ24MS+ul1GR9JO7bXAr4zVdmKAK80Bidg0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wjg3An6g6rq9jyoAy9XejRIo5MdOt8OaZv07jbbBozE=; b=bPqkFEmbcNn/TgU6I7EMJSdCrI4kOnN5HDA9b228HC9r8qn8lvYUUJu5Yk3MkCvvgJ AQnFd+JREZnIf5xINlWCMVTFewqz5XuSuckdP+nuuWHveG1+51s4H/zWk2jotBImSq8m nniNGnxx68EeA6+PUQXDVXam8HgHGKBI/UORtX4kjZhwcN9NOw7Qe6ixWhZ2CNDMuQBl p6OqWTAKY5bhTTo0F1IKXGjYsWvkhgbb3HSPB9febmyEzF40fS/09ZeJdMuzl1Ow21N8 RSqt6EbftuFEVpZw8MtKFovlQJbzhhbi4nnE1UNFowITt2ToRF5uAR+If+mn4idw/nB0 hfpg== X-Gm-Message-State: APjAAAUKrFm+kv187CIvyC6n+k80AsQ/kbQRr6sRp5qOM/FovoO2cIgF UIgISUhiDRsNjvuukLNNYXdxH4VLIjEfrw== X-Google-Smtp-Source: APXvYqzxNaIWilY8EF5FIIXk/t0Cc1IYliqWdGnT9uu0/knWYbiQxIoNEZqqqxC/5z75p7cPJJO1OA== X-Received: by 2002:a17:906:4694:: with SMTP id a20mr118715883ejr.67.1564999658266; Mon, 05 Aug 2019 03:07:38 -0700 (PDT) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com. [209.85.128.53]) by smtp.gmail.com with ESMTPSA id i8sm19792777edg.12.2019.08.05.03.07.38 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 05 Aug 2019 03:07:38 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id p74so74104179wme.4 for ; Mon, 05 Aug 2019 03:07:38 -0700 (PDT) X-Received: by 2002:a1c:343:: with SMTP id 64mr18771116wmd.116.1564999171311; Mon, 05 Aug 2019 02:59:31 -0700 (PDT) MIME-Version: 1.0 References: <20190611035344.29814-1-jungo.lin@mediatek.com> <20190611035344.29814-7-jungo.lin@mediatek.com> <20190710095429.GA181405@chromium.org> <1563424741.1212.212.camel@mtksdccf07> <1563942689.1212.494.camel@mtksdccf07> <1564363089.1212.636.camel@mtksdccf07> <1564451089.1212.649.camel@mtksdccf07> In-Reply-To: <1564451089.1212.649.camel@mtksdccf07> From: Tomasz Figa Date: Mon, 5 Aug 2019 18:59:19 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC,v3 6/9] media: platform: Add Mediatek ISP P1 V4L2 functions To: Jungo Lin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_030739_767194_C000DA44 X-CRM114-Status: GOOD ( 27.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , Mauro Carvalho Chehab , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , srv_heupstream , Rob Herring , =?UTF-8?B?UnlhbiBZdSAo5L2Z5a2f5L+uKQ==?= , =?UTF-8?B?RnJhbmtpZSBDaGl1ICjpgrHmloflh7Ep?= , Hans Verkuil , Matthias Brugger , Sj Huang , "moderated list:ARM/Mediatek SoC support" , Laurent Pinchart , ddavenport@chromium.org, =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jungo, On Tue, Jul 30, 2019 at 10:45 AM Jungo Lin wrote: > > On Mon, 2019-07-29 at 19:04 +0900, Tomasz Figa wrote: > > On Mon, Jul 29, 2019 at 10:18 AM Jungo Lin wrote: > > > On Fri, 2019-07-26 at 14:49 +0900, Tomasz Figa wrote: > > > > On Wed, Jul 24, 2019 at 1:31 PM Jungo Lin wrote: > > > > > On Tue, 2019-07-23 at 19:21 +0900, Tomasz Figa wrote: > > > > > > On Thu, Jul 18, 2019 at 1:39 PM Jungo Lin wrote: > > > > > > > On Wed, 2019-07-10 at 18:54 +0900, Tomasz Figa wrote: > > > > > > > > On Tue, Jun 11, 2019 at 11:53:41AM +0800, Jungo Lin wrote: [snip] > > > > > > > > > + > > > > > > > > > + dev_dbg(dev, "%s: node:%d fd:%d idx:%d\n", > > > > > > > > > + __func__, > > > > > > > > > + node->id, > > > > > > > > > + buf->vbb.request_fd, > > > > > > > > > + buf->vbb.vb2_buf.index); > > > > > > > > > + > > > > > > > > > + /* For request buffers en-queue, handled in mtk_cam_req_try_queue */ > > > > > > > > > + if (vb->vb2_queue->uses_requests) > > > > > > > > > + return; > > > > > > > > > > > > > > > > I'd suggest removing non-request support from this driver. Even if we end up > > > > > > > > with a need to provide compatibility for non-request mode, then it should be > > > > > > > > built on top of the requests mode, so that the driver itself doesn't have to > > > > > > > > deal with two modes. > > > > > > > > > > > > > > > > > > > > > > The purpose of non-request function in this driver is needed by > > > > > > > our camera middle-ware design. It needs 3A statistics buffers before > > > > > > > image buffers en-queue. So we need to en-queue 3A statistics with > > > > > > > non-request mode in this driver. After MW got the 3A statistics data, it > > > > > > > will en-queue the images, tuning buffer and other meta buffers with > > > > > > > request mode. Based on this requirement, do you have any suggestion? > > > > > > > For upstream driver, should we only consider request mode? > > > > > > > > > > > > > > > > > > > Where does that requirement come from? Why the timing of queuing of > > > > > > the buffers to the driver is important? > > > > > > > > > > > > [snip] > > > > > > > > > > Basically, this requirement comes from our internal camera > > > > > middle-ware/3A hal in user space. Since this is not generic requirement, > > > > > we will follow your original suggestion to keep the request mode only > > > > > and remove other non-request design in other files. For upstream driver, > > > > > it should support request mode only. > > > > > > > > > > > > > Note that Chromium OS will use the "upstream driver" and we don't want > > > > to diverge, so please make the userspace also use only requests. I > > > > don't see a reason why there would be any need to submit any buffers > > > > outside of a request. > > > > > > > > [snip] > > > > > > Ok, I have raised your concern to our colleagues and let him to discuss > > > with you in another communication channel. > > > > > > > Thanks! > > > > Best regards, > > Tomasz > > Our colleague is preparing material to explain the our 3A/MW design. If > he is ready, he will discuss this with you. Thanks! > > In the original plan, we will deliver P1 v4 patch set tomorrow (31th > Jul.). But, there are some comments waiting for other experts' input. > Do you suggest it is better to resolve all comments before v4 patch set > submitting or continue to discuss these comments on v4? For the remaining v4l2-compliance issues, we can postpone them and keep on a TODO list in the next version. Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel