From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76480C433E7 for ; Wed, 14 Oct 2020 11:50:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECA3420848 for ; Wed, 14 Oct 2020 11:50:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CEICM8xm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="D5mF2XYQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECA3420848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lT30jhC+GG72LKTNbFHuApZ4YDG2xsPV/k1oC0Ic7ak=; b=CEICM8xmng74nkACvjsXLT7WY R2wmtM177l9Tx3JaXiPezbvsIWWxNGWKdiE8Ihe7q88PmFVBZWroyHoN1+llwN9Ket+iiv7zYjKtt zf3D/6pOQrq1ALlWfTY/cv9/TMbTyol+7OAvw4CnRgBgnIpvi78txPLxYBEGjyeMzLzXxZaQUduCi xgYpR6rRU0oYHi4HjnPmW88I9qDcwDYzxr76vdwfkHNdMrLuXMjtRbbPEbGcH9uzvYxLDUrUB9pvW IXsDRKgiOhFRcPNS/0ps1xY6Pc1Tow0NK9vuuUvcAiE+wxm1K8s4yZF5IyOLB2eOMMVRjsFZPr+3o INdgyDTyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSfGZ-0000ue-WC; Wed, 14 Oct 2020 11:48:24 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSfGX-0000to-3o for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 11:48:22 +0000 Received: by mail-ed1-x544.google.com with SMTP id dg9so2745349edb.12 for ; Wed, 14 Oct 2020 04:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gJmE+QzQPKhmVzRh7Mt/ZkUz7d1ef3q7Sc2eKrUP1ek=; b=D5mF2XYQNP+94me/VxKUFpADGfBIU3L6stuWHfhcFjpvl8cFllEzVr2R8gPiy6Y7H5 7Jn3E05QFxVTs6FWqON6/czE5exVhvHc+PXVrpU6cNV+QSHwvK363vZMM69bEwZ7xq1k 1wMTxa2lATKEQ127Aj9A7/xrT5lOpm18mHUOY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gJmE+QzQPKhmVzRh7Mt/ZkUz7d1ef3q7Sc2eKrUP1ek=; b=uNZNScx7yKh/9FLMqWkrVd7bnItNjK62X+2YfFHZVYsdTOLrPDouYmOSFFc4BOVAcw s+3WecEXGAROviKJ+1Lcq81z3xQHNAEF5cNRTfnn9UYZWfPPJnClu4hi/erSlt/5OahZ l2x2vaIpexUEO4ecTUyILBGxGsXevYmpTVEH73hd5Mwy7orLWCM4FIysBCoTbPyi59a/ N0WAytKyJLiqsNGO1xcGAZtQkFYAD63T6RXK050by7Mpf/qBnaZDJAw6plyTzuTF3EtW Unyw8zN2c1QsPku+OeSF0IX120JKKbe5WLyAVmLcCX0J/8NgX5Fmb9Kqs1bkTprYes4/ Z4ww== X-Gm-Message-State: AOAM533Aa2tF1nv/shvRvudmgxexJzB//GT7xqJd5qU1U1lbO2RGCtWf eaYybNMAh1IJXs3N1Ez24wopsHj/HPtyKw== X-Google-Smtp-Source: ABdhPJz413MnbbFxqdYDHGdeD5zw1cW7273Q0oKc41bv/r1rmiXwmAKKkY56FSf5NzE9epXyzgtfAg== X-Received: by 2002:aa7:d3d0:: with SMTP id o16mr4852017edr.47.1602676094693; Wed, 14 Oct 2020 04:48:14 -0700 (PDT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id h26sm1437743edr.71.2020.10.14.04.48.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 04:48:13 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id i1so3483352wro.1 for ; Wed, 14 Oct 2020 04:48:12 -0700 (PDT) X-Received: by 2002:adf:ab05:: with SMTP id q5mr4966749wrc.32.1602676092220; Wed, 14 Oct 2020 04:48:12 -0700 (PDT) MIME-Version: 1.0 References: <20201013130503.2412-1-dongchun.zhu@mediatek.com> <20201013130503.2412-2-dongchun.zhu@mediatek.com> <20201013161938.GE13341@paasikivi.fi.intel.com> <1602641418.4733.80.camel@mhfsdcap03> <20201014083139.GG13341@paasikivi.fi.intel.com> In-Reply-To: <20201014083139.GG13341@paasikivi.fi.intel.com> From: Tomasz Figa Date: Wed, 14 Oct 2020 13:48:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings To: Sakari Ailus X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_074821_167587_E0BDF4EC X-CRM114-Status: GOOD ( 30.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , =?UTF-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , Louis Kuo , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dongchun Zhu , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 10:31 AM Sakari Ailus wrote: > > On Wed, Oct 14, 2020 at 10:10:18AM +0800, Dongchun Zhu wrote: > > Hello Sakari, > > > > Thanks for your timely review. > > > > On Tue, 2020-10-13 at 19:19 +0300, Sakari Ailus wrote: > > > Hi Dongchun, > > > > > > On Tue, Oct 13, 2020 at 09:05:02PM +0800, Dongchun Zhu wrote: > > > > Add YAML device tree binding for OV02A10 CMOS image sensor, and the > > > > relevant MAINTAINERS entries. > > > > > > > > Signed-off-by: Dongchun Zhu > > > > --- > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 162 +++++++++++++++++++++ > > > > MAINTAINERS | 7 + > > > > 2 files changed, 169 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > [snip]... > > > > > > + ovti,mipi-clock-voltage: > > > > + description: > > > > + An array of 2-tuples items, and each item consists of link frequency and > > > > + MIPI clock voltage unit like . Clock voltage unit is > > > > + dependent upon link speed, indicating MIPI transmission speed select that > > > > + controls D-PHY timing setting by adjusting MIPI clock voltage to improve > > > > + the clock driver capability. > > > > + $ref: "/schemas/types.yaml#/definitions/uint32-array" > > > > + minItems: 2 > > > > + default: [390000, 4] > > > > > > Why do you have the link frequency here as well? > > > > > > In principle this does belong to the endpoint as link frequencies are > > > specific to that, but I don't mind; there's just a single port anyway. > > > > > > > This is an optional property which we model as an array of > clock voltage> pairs. An example to have all link speeds up to 390MHz > > use the value 4 for current driver. If one wants to select different > > voltage for different link, they could do so as well. > > If you think you'd need that, then you need to put this to the endpoint. The mipi-clock-voltage property is not a property of the endpoint. The link frequency there does not set the link frequency - it only specifies which link frequency the given voltage should be used for. Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel