From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81221C07E99 for ; Fri, 9 Jul 2021 10:28:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45DA061248 for ; Fri, 9 Jul 2021 10:28:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45DA061248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hvn97MWD5ZjCwJSLb1z7o+Nau4cgGTWlUlNM4h9qSlo=; b=t/1zgnU/6PjQXl ywKuoF/+LbvPZUs7HETgYk5wRJuWLVmtfodsWPD+3CVeHtbJZ6/PCd9x3zQEM+fW3wpx4DpddQIip KeQAaKQbYrhW1XZECEgLgpex8f/NVxXkn/0tKfTtSdXZ+oD9SpkDV/rlGNdYKTn9FYjUk0xEinalu +vuHY/QOTFuDxCIJ2BkjpWCyH9kh0SU9F8+vaVzzpzB1o9zHntISasZlGXmZJrDHnsJ/Rpmxlfm73 Bz4eBgQqvOTG84VCpn1Q6Hl5zKNki7/YOG3yI9SJyYLHfRPBKPKRTHlWf2Z2jgwq6fdJfYDFH8w+h BRwKFH+wGsc5m7ELayCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1nig-001VOm-Ix; Fri, 09 Jul 2021 10:26:54 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1niZ-001VLI-7B for linux-arm-kernel@lists.infradead.org; Fri, 09 Jul 2021 10:26:48 +0000 Received: by mail-ej1-x636.google.com with SMTP id c17so15204715ejk.13 for ; Fri, 09 Jul 2021 03:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EE3G7qk9YjV6WICjXG49f7wI9xsGOugrChSPRCk7KBY=; b=j6ueWrIhKJIqX+ueklioki6dIG0OTnmNayymWlaVcRO1HjVRRLInq8113rpC0VzsJE LJlOHhgMqrPL7AbRHbdrjOpH5SkezCozW4eeIWh4PO1FXTa5NEVaruBmAWnQGauz7eGj FQ2l2WvAoKeryPAxZP6iCnPC+YpHdEbovQavQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EE3G7qk9YjV6WICjXG49f7wI9xsGOugrChSPRCk7KBY=; b=Kro6JfHKUJnbp+CDH9w/ECvgkoCv/Vi2UO/rjOZS0p5XMnrIj55b26f49MxWR3ShLy 28vqrQEp9XqZGZU1AJsUmbeSphkwgfJ20s8RPtk9+THmjh8E1R6Yp5enzAD82VlO29nE pcUn/ZZCWcjWr7qSRZo6GVbUe/B9jGfyZ5Pj11rXPH5ncmtYAJnAvpy5N2Xlv3PxnkYM SxMA7kaCT2IGi1U0IkRs+nlkKDW9ZzNu2Zs3F+m/4ToJT01mkvpfEjzi7Gn6Q4KlFG8y uQ2/Cu+3Ba0ZsEySirftB4c5qiv655PgsLXoOtIvq8pQ2dyaHuXlqEZsxfm/RiuU2rTz Htzw== X-Gm-Message-State: AOAM531/P20HLJ7BbBaWDYBs0mQUjSWdtsOtQ7BhWuGXiOMNGcWcjm2I ZZsj0/1C18xkg0c38qqfp/yFa5XugZaH6zcO X-Google-Smtp-Source: ABdhPJxeMK6xeAFu3A/rtgfxk1OxkjWMmfNvOjYX9IvRLXKeTtFj7dKJhlXbAZHXEe0iV4SNoQs4Og== X-Received: by 2002:a17:906:585a:: with SMTP id h26mr36867307ejs.31.1625826404222; Fri, 09 Jul 2021 03:26:44 -0700 (PDT) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com. [209.85.221.54]) by smtp.gmail.com with ESMTPSA id p3sm811313ejy.20.2021.07.09.03.26.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jul 2021 03:26:43 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id f17so11472552wrt.6 for ; Fri, 09 Jul 2021 03:26:43 -0700 (PDT) X-Received: by 2002:adf:f1c9:: with SMTP id z9mr12812492wro.159.1625826403104; Fri, 09 Jul 2021 03:26:43 -0700 (PDT) MIME-Version: 1.0 References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> In-Reply-To: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> From: Tomasz Figa Date: Fri, 9 Jul 2021 19:26:31 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2,0/9] Support jpeg encode for MT8195 To: "kyrie.wu" Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Xia.Jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210709_032647_316446_C2626E4A X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kyrie, On Wed, Jun 30, 2021 at 4:31 PM kyrie.wu wrote: > > add component framework to using multi-HW for MT8195 jpeg encode. > > kyrie.wu (9): > dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible > media: mtk-jpegenc: Add MT8195 JPEG venc driver > media: mtk-jpegenc: remove redundant code of irq > media: mtk-jpegenc: Refactor jpeg clock interface > media: mtk-jpegenc: Generalize jpeg encode irq interfaces > media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces > media: mtk-jpegenc: Use component framework to manage each hardware > information > media: mtk-jpegenc: Generalize jpegenc HW operations interfaces > media: mtk-jpegenc: Refactor jpegenc device run interface > > .../bindings/media/mediatek-jpeg-encoder.yaml | 3 + > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 600 +++++++++++++++++---- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 69 ++- > drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c | 208 +++++++ > 4 files changed, 786 insertions(+), 94 deletions(-) > > --- > This patch dependents on "dt-bindings: mediatek: convert mtk jpeg decoder/encoder to yaml"[1] > > Please also accept this patch together with [1]. > > [1]https://lore.kernel.org/patchwork/patch/1445298/ Thank you for the series. However, I gave reviewing it a try and unfortunately had a very hard time following it, because of the way the patches are organized. Please make sure to read and understand the kernel patch submission guide[1], adjust the series appropriately and send a new version which I'll review. [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel