From: govindraj.ti@gmail.com (Govindraj)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 09/15] OMAP2+: UART: Add runtime pm support for omap-serial driver
Date: Thu, 22 Sep 2011 13:25:36 +0530 [thread overview]
Message-ID: <CAAL8m4zzynRm+c1xiwu117OkkX4X2ERoTDBPDL7XsihVcEL53g@mail.gmail.com> (raw)
In-Reply-To: <CACVXFVMpvF5foA1asLYE5WbvHQ3b_eXaBpiMT7Q1h0KHDGLSCg@mail.gmail.com>
On Thu, Sep 22, 2011 at 1:18 PM, Ming Lei <tom.leiming@gmail.com> wrote:
> Hi,
>
> On Wed, Sep 21, 2011 at 8:13 PM, Govindraj.R <govindraj.raja@ti.com> wrote:
>> Adapts omap-serial driver to use pm_runtime API's.
>
>> ? ? ? ?console_unlock();
>>
>> - ? ? ? if ((cpu_is_omap34xx() && bdata->pads) ||
>> - ? ? ? ? ? ? ? (pdata->wk_en && pdata->wk_mask))
>> + ? ? ? if ((cpu_is_omap34xx() && bdata->pads))
>> ? ? ? ? ? ? ? ?device_init_wakeup(&pdev->dev, true);
>
> Just a bit curious, why doesn't the code enable wakeup at default
> on omap4, which will disable runtime pm of serial port on omap4.
>
yes sure will add for omap4.
> I have tested your patches on omap4 panda(enable wakeup at
> default manually), runtime pm of serial port 2 can work well and
> remote wakeup too.
>
Thanks, for testing.
--
Govindraj.R
prev parent reply other threads:[~2011-09-22 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 12:13 [PATCH v5 03/15] OMAP2+: UART: cleanup + remove uart pm specific API Govindraj.R
2011-09-21 12:13 ` [PATCH v5 04/15] OMAP2+: UART: cleanup 8250 console driver support Govindraj.R
2011-09-21 12:13 ` [PATCH v5 05/15] OMAP2+: UART: Cleanup part of clock gating mechanism for uart Govindraj.R
2011-09-21 12:13 ` [PATCH v5 06/15] OMAP2+: UART: Remove certain feilds from omap_uart_state struct Govindraj.R
2011-09-21 12:13 ` [PATCH v5 07/15] OMAP2+: UART: Add default mux for all uarts Govindraj.R
2011-09-21 12:13 ` [PATCH v5 08/15] OMAP2+: UART: Store certain reg values to port structure Govindraj.R
2011-09-21 12:13 ` [PATCH v5 09/15] OMAP2+: UART: Add runtime pm support for omap-serial driver Govindraj.R
2011-09-22 7:48 ` Ming Lei
2011-09-22 7:55 ` Govindraj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAL8m4zzynRm+c1xiwu117OkkX4X2ERoTDBPDL7XsihVcEL53g@mail.gmail.com \
--to=govindraj.ti@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).