linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matthijsvanduin@gmail.com (Matthijs van Duin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep
Date: Mon, 1 Jun 2015 02:20:08 +0200	[thread overview]
Message-ID: <CAALWOA8ReuBSMcu5EvLOrKGfFGBGWSdMhpL_uSnL4QvTC-n8zg@mail.gmail.com> (raw)
In-Reply-To: <1432136322-7609-1-git-send-email-robertcnelson@gmail.com>

Sorry for the late response, I only just noticed this since I wasn't CC'd.

This "fix" was not ever Reported-By or Tested-By me as it claims. It
is in fact wrong: &rtc { system-power-controller; } needs to be
present for every variety of beaglebone (more generally every design
with a TPS65217 whose PWR_EN is connected to the PMIC_POWER_EN pin of
an AM335x).

Without a system-power-controller, the kernel has no way of turning
off the system and shutdown will leave the system halted instead.

The previously posted fix, which added  &tps {
ti,pmic-shutdown-controller; }  was correct, and ensures that a
poweroff makes the pmic enter "OFF-state" rather than "SLEEP-state"
(aka RTC-only sleep).

Matthijs

  parent reply	other threads:[~2015-06-01  0:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 15:38 [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep Robert Nelson
2015-05-20 16:47 ` Tony Lindgren
2015-06-01  0:20 ` Matthijs van Duin [this message]
2015-06-01  2:18   ` Robert Nelson
2015-06-01  5:14     ` Matthijs van Duin
2015-06-01 17:23       ` Tony Lindgren
2015-06-01 19:33         ` Matthijs van Duin
2015-06-01 20:01           ` Tony Lindgren
2015-06-11 14:18             ` [PATCH] Revert "ARM: dts: am335x-boneblack: disable RTC-only sleep" Johan Hovold
2015-07-06 12:16               ` Tony Lindgren
2015-06-01 17:12     ` [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAALWOA8ReuBSMcu5EvLOrKGfFGBGWSdMhpL_uSnL4QvTC-n8zg@mail.gmail.com \
    --to=matthijsvanduin@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).