From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FF8C10F11 for ; Wed, 10 Apr 2019 07:36:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15D0D21841 for ; Wed, 10 Apr 2019 07:36:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AgfcUh6e"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=boundarydevices-com.20150623.gappssmtp.com header.i=@boundarydevices-com.20150623.gappssmtp.com header.b="fYVqrLWm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15D0D21841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=boundarydevices.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=41zW6TBCSA1/t6MhWg88Z8JYS52vUrF4YhyL7BNzLtw=; b=AgfcUh6ebhaA34 tJAxQYId1pYs6tD2wWnFsUt3Ncgb9IZclIdEQnr5XFsoyfuTY0mneMYhm6I4EGdXGMtQgGgxdMI5H IXRjzH66BD3u32mhpnwPNYeIrQ6j0lEiOPKwLCAxLSIBs83bHeiCx+HEZiaxkm9uq001A8qqGOdU/ KGVihwMe1+JNE4d2SMbAD2iz+rbz5fhJcQDUfVrucN1Yt8aJkw5PXyGE0OL/u9yAiNc9xrMixi4om 0TAFZZz0gf8//e3yXZVhBnpy4oWkUn5gSNnI8g18LLDzgAP4yhKQdD5UEApFY19a1GM6oHacyIITJ wtGc0HJ9MhFwP5/V6//Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE7mA-000460-91; Wed, 10 Apr 2019 07:36:06 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hE7m6-00045K-KB for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 07:36:04 +0000 Received: by mail-qt1-x844.google.com with SMTP id h39so1770451qte.2 for ; Wed, 10 Apr 2019 00:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JyF8Y8lqtTJiU7zBDRtefa/bIG2gPtY3Rz9qH5PAR9U=; b=fYVqrLWmBybiD3LRsjwCfu9cXQe2fiUlCS5X32h/AuMYAO1yUafWQVJ+zHAcmI5H3P 4h1+ipPqGL2ASOOns7tXZr7FwPiKQx1mV4lSaivYnNI8G7n+p1qbgwZb6CAPtXUJuIC2 pP2AFtvwTVNFsXFhiRBgro0IGeaKHkilH71yDJJ4fTyHIptJXZwrvMQ4TrdEhT2t/Om6 2M0cHrwFbEseYZYpjZz1P1DSi0FIU4xrGMVEmhg5WuSnvw8sh26aPITEoA8WIBDJa8Uq y8b4VQEsGwNFzx4ADwZyqFd4yitAvKxkM7s7CWkNlwiapHM1nHOKBe+PA2FrKIDt68q6 +94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JyF8Y8lqtTJiU7zBDRtefa/bIG2gPtY3Rz9qH5PAR9U=; b=GYAv6mnoRCF+OjNJfaqEYzekAk8Kz/NI/JtSu62DjsVnX1s45hQkrF7+I1NrkIXtU/ cA9duSn2u18X70ETpkRMVEDONBrxrL4FQJTDUfOCOrqAkRs1ICu48Bi+KkP7SDshLX6C 9rGiTASzoiu0VQQ7nEfeJwnzS0gauHlfZAtJQyNM6K0uV6j7OJ1aIslPHMIwMEdukyxP mf+qbyKuid2h3RlUqwGQQ7c2RyyCGiJN4xZcjxVMyiqPZPrYB3UgLMbnTmwjx6LIh66g 6S/Pd/6mnrILC083q+HDl0ryR6vZw/KgaFFdOiQItN/LlYRFDHmsq6GqEWwUta0hcLDY vt5g== X-Gm-Message-State: APjAAAXciB4KBvfrz8GzMzXxzChDR3e+D64k0h2K/EXGLFJQf1yWPezK Ng55OAiCXbjg6uVdxWL2lJQ8LdosMmoBFi6xlvuOvg== X-Google-Smtp-Source: APXvYqwzGCxzPUxtzOkzbRJg3W+2pMr/P9gqBzdBjkDJ5Dz9usp+mG/tkSnQo4FFukYy3dschWHM58rbSLzRQMXwEy0= X-Received: by 2002:a0c:b505:: with SMTP id d5mr34229775qve.62.1554881760979; Wed, 10 Apr 2019 00:36:00 -0700 (PDT) MIME-Version: 1.0 References: <20190408175319.9106-1-robert.foss@collabora.com> <4fd506a1-c961-0569-6d39-283758f363d9@collabora.com> In-Reply-To: <4fd506a1-c961-0569-6d39-283758f363d9@collabora.com> From: Gary Bisson Date: Wed, 10 Apr 2019 09:35:50 +0200 Message-ID: Subject: Re: [PATCH] ARM: dts: imx6qdl-nitrogen6_max: Disable LVDS channels To: Robert Foss X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_003602_812491_2B7640F4 X-CRM114-Status: GOOD ( 23.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Fabio Estevam , Sascha Hauer , linux-kernel , Troy Kisky , Rob Herring , NXP Linux Team , Sascha Hauer , Fabio Estevam , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Apr 9, 2019 at 2:07 AM Robert Foss wrote: > > Hey Fabio, > > On 4/8/19 10:37 PM, Fabio Estevam wrote: > > Hi Robert, > > > > [Adding Gary] Adding Troy, I'm no longer a full-time employee at Boundary Devices. > > On Mon, Apr 8, 2019 at 2:54 PM Robert Foss wrote: > >> > >> If a LVDS device is not connected, having the LVDS channels > >> enabled will prevent imx-ldb from probing correctly even > >> if other CRTCs are connected. > >> > >> Signed-off-by: Robert Foss > >> --- > >> arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > >> index 39200e5dc896..5b413cf4c250 100644 > >> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > >> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > >> @@ -703,7 +703,7 @@ > >> status = "okay"; > >> > >> lvds-channel@0 { > >> - status = "okay"; > >> + status = "disabled"; > >> > >> port@4 { > >> reg = <4>; > >> @@ -715,7 +715,7 @@ > >> }; > >> > >> lvds-channel@1 { > >> - status = "okay"; > >> + status = "disabled"; > > > > I am not sure I understood what you are trying to fix. > > If CONFIG_DRM_IMX_LDB is enabled, LVDS DT channels are enabled > and no LVDS-panels are connected the imx-ldb driver will > fail to bind. > > This is a problem, since it will prevent other actually connected > display output from being used, even if they bind properly. > > > > > Could you please share some logs when imx-ldb fails to probe correctly? > > > [ 2.119563] component_bind_all() trying to bind: ldb > [ 2.124600] imx-drm display-subsystem: binding ldb (ops imx_ldb_ops) > [ 2.146169] drm_of_find_panel_or_bridge() np->name=lvds-channel np->type= > [ 2.153709] drm_of_find_panel_or_bridge() no panel found for remote > [ 2.160081] drm_of_find_panel_or_bridge() bridge needed > [ 2.162043] drm_of_find_panel_or_bridge() bridge not found > [ 2.165331] drm_of_find_panel_or_bridge() failed > [ 2.170023] imx-drm display-subsystem: failed to bind ldb (ops imx_ldb_ops): -517 > > This at the same time as HDMI binds properly: > > [ 4.458954] dwhdmi-imx 120000.hdmi: Detected HDMI TX controller v1.30a with > HDCP (DWC HDMI 3D TX PHY) > [ 4.469633] imx-drm display-subsystem: bound 120000.hdmi (ops dw_hdmi_imx_ops) > > Which in the end causes the IMX driver to not initialize properly > and ignore the HDMI connection that bound properly. > This in turn prevents us from having any graphical output while there > is no LVDS panel connected. Does this happen if the LVDS is disabled in cmdline? (adding "video=LVDS-1:d") Note that a bootscript was written for mainline kernel that takes care of display configuration [1]. Currently this bootscript disables all the displays that aren't used. It was tested with HDMI, where LVDS and LCD display are disabled, and it *used to* work. If this doesn't work then there's most likely a regression somewhere. Regards, Gary [1] https://github.com/boundarydevices/u-boot-imx6/blob/boundary-v2018.07/board/boundary/bootscripts/bootscript-mainline.txt#L90 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel