linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gnurou@gmail.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: tegra: Add missing Smaug revision
Date: Thu, 30 Jun 2016 15:04:22 +0900	[thread overview]
Message-ID: <CAAVeFu++3FcPF=j-DAsoA5O5kt6BDPYYT-EeSpEF2u=8E7U9ig@mail.gmail.com> (raw)
In-Reply-To: <57738EC3.3070200@nvidia.com>

On Wed, Jun 29, 2016 at 6:02 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
>
> On 29/06/16 09:52, Alexandre Courbot wrote:
>> The "google,smaug-rev2" string is missing from the compatible list of
>> Smaug's DT. The differences of rev2 are not relevant at our current
>> level of support and it boots just fine, so add it.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>>  arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> index 431266a48e9c..82a96bd27bc8 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> @@ -11,7 +11,8 @@
>>       compatible = "google,smaug-rev8", "google,smaug-rev7",
>>                    "google,smaug-rev6", "google,smaug-rev5",
>>                    "google,smaug-rev4", "google,smaug-rev3",
>> -                  "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
>> +                  "google,smaug-rev2", "google,smaug-rev1",
>> +                  "google,smaug", "nvidia,tegra210";
>>
>>       aliases {
>>               serial0 = &uarta;
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
>
> Olof, let us know if you have any comments on this? Looks like I missed
> this initially because the rev2 support had been broken out in the
> chrome-os kernel tree to support some specific features for this board.
> However, I think for now it is ok to include rev2 here as well for mainline.

This should be perfectly safe. If I run a diff between
tegra210-smaug-p1.dts and tegra210-smaug-p2.dts in the ChromeOS tree,
the only node that differs is sysedp-batmon-calc. The other node in
these files (spiflash) is identical.

Besides I don't think there are that many rev2s out there. :)

  reply	other threads:[~2016-06-30  6:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29  8:52 [PATCH] arm64: tegra: Add missing Smaug revision Alexandre Courbot
2016-06-29  9:02 ` Jon Hunter
2016-06-30  6:04   ` Alexandre Courbot [this message]
2016-06-30 16:15 ` Andrew Bresticker
2016-09-16  8:19   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAVeFu++3FcPF=j-DAsoA5O5kt6BDPYYT-EeSpEF2u=8E7U9ig@mail.gmail.com' \
    --to=gnurou@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).